Plumb entire lockfile/internal only code through create_pex_from_targets
#18622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thejcannon
added
needs-cherrypick
category:bugfix
cognifloyd
approved these changes
Mar 31, 2023
jsirois
reviewed
Mar 31, 2023
jsirois
approved these changes
Mar 31, 2023
benjyw
approved these changes
Mar 31, 2023
benjyw
pushed a commit
to benjyw/pants
that referenced
this pull request
Mar 31, 2023
…gets` (pantsbuild#18622) Previously if `_determine_requirements_for_pex_from_targets` returns a `PexRequest` we'd short-circuit the rest of of the code resulting in `main` not being set on the PEX that we run (most likely in addition to other bugs like local dists not existing either). Refactored so that in this very specific case, we'd still make it through the rest of the code, leveraging `pex_path` for the repo PEX. Fixes pantsbuild#18552
benjyw
pushed a commit
to benjyw/pants
that referenced
this pull request
Mar 31, 2023
…gets` (cherrypick pantsbuild#18622) Previously if `_determine_requirements_for_pex_from_targets` returns a `PexRequest` we'd short-circuit the rest of of the code resulting in `main` not being set on the PEX that we run (most likely in addition to other bugs like local dists not existing either). Refactored so that in this very specific case, we'd still make it through the rest of the code, leveraging `pex_path` for the repo PEX. Fixes pantsbuild#18552
benjyw
pushed a commit
to benjyw/pants
that referenced
this pull request
Mar 31, 2023
…gets` (cherry-pick of pantsbuild#18622) Previously if `_determine_requirements_for_pex_from_targets` returns a `PexRequest` we'd short-circuit the rest of of the code resulting in `main` not being set on the PEX that we run (most likely in addition to other bugs like local dists not existing either). Refactored so that in this very specific case, we'd still make it through the rest of the code, leveraging `pex_path` for the repo PEX. Fixes pantsbuild#18552
benjyw
added a commit
that referenced
this pull request
Mar 31, 2023
…gets` (Cherry-pick of #18622) (#18634) Previously if `_determine_requirements_for_pex_from_targets` returns a `PexRequest` we'd short-circuit the rest of of the code resulting in `main` not being set on the PEX that we run (most likely in addition to other bugs like local dists not existing either). Refactored so that in this very specific case, we'd still make it through the rest of the code, leveraging `pex_path` for the repo PEX. Fixes #18552 Co-authored-by: Joshua Cannon <joshdcannon@gmail.com>
jsirois
pushed a commit
that referenced
this pull request
Mar 31, 2023
…gets` (cherry-pick of #18622) (#18636) Previously if `_determine_requirements_for_pex_from_targets` returns a `PexRequest` we'd short-circuit the rest of of the code resulting in `main` not being set on the PEX that we run (most likely in addition to other bugs like local dists not existing either). Refactored so that in this very specific case, we'd still make it through the rest of the code, leveraging `pex_path` for the repo PEX. Fixes #18552 Co-authored-by: Joshua Cannon <joshdcannon@gmail.com>
jsirois
pushed a commit
that referenced
this pull request
Mar 31, 2023
…gets` (cherry-pick of #18622) (#18635) Previously if `_determine_requirements_for_pex_from_targets` returns a `PexRequest` we'd short-circuit the rest of of the code resulting in `main` not being set on the PEX that we run (most likely in addition to other bugs like local dists not existing either). Refactored so that in this very specific case, we'd still make it through the rest of the code, leveraging `pex_path` for the repo PEX. Fixes #18552 Co-authored-by: Joshua Cannon <joshdcannon@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously if
_determine_requirements_for_pex_from_targetsreturns aPexRequestwe'd short-circuit the rest of of the code resulting inmainnot being set on the PEX that we run (most likely in addition to other bugs like local dists not existing either).Refactored so that in this very specific case, we'd still make it through the rest of the code, leveraging
pex_pathfor the repo PEX.Fixes #18552