Improve lockfile consumption error message. #18638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjyw
commented
Mar 31, 2023
| @@ -474,18 +474,19 @@ def validate_metadata( | |||
| interpreter_constraints: InterpreterConstraints, | |||
| lockfile: Lockfile, | |||
| consumed_req_strings: Iterable[str], | |||
| validate_consumed_req_strings: bool, | |||
There was a problem hiding this comment.
We now always pass the req strings through so we can use them to give more context to the user in the error message, so we add this flag to determine whether we should validate them (previously we did this by not passing the req strings in)
stuhood
approved these changes
Mar 31, 2023
benjyw
force-pushed
the
improve_error_msg
branch
from
e0f6861
to
17f4fda
Compare
benjyw
added a commit
to benjyw/pants
that referenced
this pull request
Apr 1, 2023
benjyw
added a commit
that referenced
this pull request
Apr 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.