Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: Describe relevant error modes during rule compilation #18663

Merged
merged 2 commits into from Apr 6, 2023
Merged

doc: Describe relevant error modes during rule compilation #18663

merged 2 commits into from Apr 6, 2023

Conversation

tobni
Copy link
Contributor

@tobni tobni commented Apr 3, 2023

Not sure this is the right wording, but previous iteration is misleading, especially for novices like me.

@tobni tobni mentioned this pull request Apr 3, 2023
Merged
@stuhood stuhood requested a review from kaos April 4, 2023 16:30
@stuhood stuhood added category:documentation category:bugfix Bug fixes for released features and removed category:documentation labels Apr 4, 2023
kaos
kaos approved these changes Apr 5, 2023
View reviewed changes
Copy link
Member

@kaos kaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, the wording is an accurate improvement of the current state for the @rule decorator. Thanks!

@stuhood stuhood enabled auto-merge (squash) April 6, 2023 16:06
@stuhood stuhood merged commit c49e56a into pantsbuild:main Apr 6, 2023
17 checks passed
@tobni tobni deleted the doc/better-error-on-missing-get branch May 16, 2023 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaos kaos kaos approved these changes

Assignees
No one assigned
Labels
category:bugfix Bug fixes for released features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tobni @kaos @stuhood