Add timeout to remote store calls, and adjust name of cache timeout. #18695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdyas
reviewed
Apr 6, 2023
| help="Timeout value for remote cache lookups in milliseconds.", | ||
| ) | ||
| remote_cache_rpc_timeout_millis = IntOption( |
There was a problem hiding this comment.
Would it make sense to introduce a DurationOption type?
There was a problem hiding this comment.
Which could take human-readable duration strings and convert them internally to a common format.
There was a problem hiding this comment.
Almost certainly, yea.
There was a problem hiding this comment.
Do you mind opening a ticket about that?
benjyw
approved these changes
Apr 6, 2023
stuhood
added a commit
to stuhood/pants
that referenced
this pull request
Apr 6, 2023
…antsbuild#18695) pantsbuild#16196 moved the cache read timeout down to the network layer, which made it much more accurate. But cache lookups also involve a number of calls to a remote `Store`, which did not have their own timeout. This change adds an RPC timeout for `Store` accesses to allow for retries of tar-pitted remote store RPCs, and adjusts the naming of the `--remote-cache-rpc-timeout-millis` option to make it clear that it applies to all cache operations (including writes).
stuhood
added a commit
that referenced
this pull request
Apr 7, 2023
…(Cherry-pick of #18695) (#18697) #16196 moved the cache read timeout down to the network layer, which made it much more accurate. But cache lookups also involve a number of calls to a remote `Store`, which did not have their own timeout. This change adds an RPC timeout for `Store` accesses to allow for retries of tar-pitted remote store RPCs, and adjusts the naming of the `--remote-cache-rpc-timeout-millis` option to make it clear that it applies to all cache operations (including writes).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#16196 moved the cache read timeout down to the network layer, which made it much more accurate. But cache lookups also involve a number of calls to a remote
Store, which did not have their own timeout.This change adds an RPC timeout for
Storeaccesses to allow for retries of tar-pitted remote store RPCs, and adjusts the naming of the--remote-cache-rpc-timeout-millisoption to make it clear that it applies to all cache operations (including writes).