Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit Python publishing docs for clarity. #18718

Merged
merged 3 commits into from Apr 13, 2023
Merged

Edit Python publishing docs for clarity. #18718

merged 3 commits into from Apr 13, 2023

Conversation

benjyw
Copy link
Sponsor Contributor

@benjyw benjyw commented Apr 12, 2023

No description provided.

kaos
kaos approved these changes Apr 12, 2023
View reviewed changes
Copy link
Member

@kaos kaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks 🎉

Benjy Weinberger and others added 2 commits April 12, 2023 14:41
@cognifloyd
Update docs/markdown/Python/python-goals/python-publish-goal.md
50de605 
Co-authored-by: Jacob Floyd <cognifloyd@gmail.com>
@cognifloyd
Update docs/markdown/Python/python-goals/python-publish-goal.md
291200c 
Co-authored-by: Jacob Floyd <cognifloyd@gmail.com>
@stuhood
Copy link
Sponsor Member

stuhood commented Apr 12, 2023

It would probably be useful to use this review to bootstrap an "experimental tracking ticket" for the publish goal (since it was experimental before we'd begun that convention). What are the big relevant issues related to publishing that we would want to resolve before stabilizing it?

cognifloyd
cognifloyd approved these changes Apr 12, 2023
View reviewed changes
Copy link
Member

@cognifloyd cognifloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Oh. I didn't think the core publish goal was still experimental - I thought only the twine backend (and therefore the python version of publish) was experimental.

@benjyw benjyw merged commit b69ea9c into pantsbuild:main Apr 13, 2023
17 checks passed
@benjyw benjyw deleted the clarify_twine_docs branch April 13, 2023 01:44
@benjyw
Copy link
Sponsor Contributor Author

benjyw commented Apr 13, 2023 •
edited

Tracking issue for stabilization: #18729

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaos kaos kaos approved these changes

@cognifloyd cognifloyd cognifloyd approved these changes

@chrisjrn chrisjrn Awaiting requested review from chrisjrn

@Eric-Arellano Eric-Arellano Awaiting requested review from Eric-Arellano

Assignees
No one assigned
Labels
category:documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@benjyw @stuhood @kaos @cognifloyd