Only build and release wheels for Python 3.9. #18829

benjyw · 2023-04-24T23:36:04Z

Now that scie-pants is the norm, and it provides Python 3.9,
there is no need to release for 3.7 or 3.8.

This will save us CI time as well as PyPI space.

This is a step on the road to deprecating running pants
in any way other than scie-pants. For now we still
have the escape hatch of installing Python 3.9 and
running from a ./pants script.

Once we're comfortable with this, a future change can
clean up the CI scripts, ensure that tests always run on
3.9, etc. For now this is the smallest change that
achieves the desired effect.

Eric-Arellano

Great!

Eric-Arellano · 2023-04-25T11:27:48Z

build-support/bin/generate_github_workflows.py

 PYTHON37_VERSION = "3.7"
 PYTHON38_VERSION = "3.8"


As mentioned in the PR description " a future change can clean up the CI scripts"... For now I just wanted to do the least invasive thing, until we're sure we don't need other interpreters for tests etc.

Eric-Arellano · 2023-04-25T11:28:21Z

build-support/bin/generate_github_workflows.py

@@ -75,7 +75,7 @@ def hashFiles(path: str) -> str:
 PYTHON37_VERSION = "3.7"
 PYTHON38_VERSION = "3.8"
 PYTHON39_VERSION = "3.9"
-ALL_PYTHON_VERSIONS = [PYTHON37_VERSION, PYTHON38_VERSION, PYTHON39_VERSION]
+ALL_PYTHON_VERSIONS = [PYTHON39_VERSION]


Maybe worth de-generalizing this code so that it's simpler? Sounds like we never expect to support more than 1 version at a time.

Maybe worth de-generalizing this code so that it's simpler? Sounds like we never expect to support more than 1 version at a time.

I guess that could be part of the:

Once we're comfortable with this, a future change can
clean up the CI scripts

as

[..] this is the smallest change that
achieves the desired effect.

Exactly. Right now I'm not sure if some tests are expecting a non-3.9 interpreter, or something.

jsirois

This could be a harder landing than our typical deprecation since there is 0 notice via the established console warning channel. Perhaps a pants-devel@ email / #general message is in order for those that happen to consume those channels. It seems easy to imagine corporate environments where the workaround is not viable and broader advanced warning will be appreciated.

jsirois · 2023-04-25T14:09:49Z

I think SCIE is set in the environment for Pants code to determine its launch provenance. The standard deprecation warning cycle could thus be implemented. I'm out of touch on what we consider kosher wrt most things Pants though; so I'll let you and others do with that as you will.

kaos · 2023-04-25T14:23:40Z

I agree with John concerning fair deprecation notice for this. Detecting ./pants use and flag that as deprecated with forward pointers to install and use scie-pants seems like a good preliminary step here.

But, using ./pants would still work as long as the python interpreter used is a 3.9 one, so maybe that is a useful fact to consider when issuing the deprecation notice (if Pants is running on !=3.9).

benjyw · 2023-04-25T14:40:38Z

Yeah, I agree. I will hold off on merging this until we have a deprecation solution in place.

benjyw · 2023-04-25T17:17:06Z

See #18833

kaos · 2023-04-25T18:08:42Z

That means holding this until after 2.17.0a0 has been cut, right?

benjyw · 2023-04-25T20:17:56Z

Yeah, exactly, I will sit on this for now.

benjyw · 2023-05-21T15:27:58Z

Merging this now!

thejcannon · 2023-05-21T19:49:05Z

Awesome. Now let's jump to 3.11 🚀

Internal changes: * Fix TypedDict construction ([pantsbuild#19166](pantsbuild#19166)) * Have package_dists.InvalidEntryPoint subclass InvalidFieldException ([pantsbuild#19149](pantsbuild#19149)) * Check for `CI=true`, not `CI=1` for cherry-picking ([pantsbuild#19141](pantsbuild#19141)) * Set up remote caching in CI ([pantsbuild#19144](pantsbuild#19144)) * refactor(internal): adjust pants_venv venv_dir calculation ([pantsbuild#19140](pantsbuild#19140)) * Prepare `2.16.0rc4`. ([pantsbuild#19146](pantsbuild#19146)) * Warn about `files()` in PEXes in one place ([pantsbuild#19027](pantsbuild#19027)) * Drop our explicit dep on `syn` ([pantsbuild#19134](pantsbuild#19134)) * Fix auto-cherry-picker's merge-conflicts ([pantsbuild#19125](pantsbuild#19125)) * Use explicit depths on fetches when running cherry-picks in CI ([pantsbuild#19127](pantsbuild#19127)) * Make determine_python() pin to 3.9 ([pantsbuild#19116](pantsbuild#19116)) * Upgrade to `actions/checkout@v3` ([pantsbuild#19112](pantsbuild#19112)) * Run the cherry pick script with `-x` for debugging ([pantsbuild#19095](pantsbuild#19095)) * Add more linux x86 test CI shards ([pantsbuild#19099](pantsbuild#19099)) * Use a trait for remote ByteStore network implementation ([pantsbuild#19050](pantsbuild#19050)) * Increase the logging of release version file publishing. ([pantsbuild#19092](pantsbuild#19092)) * Remove the Toolchain plugin ([pantsbuild#18978](pantsbuild#18978)) * Fix bad merge of pantsbuild#18829. ([pantsbuild#19080](pantsbuild#19080)) * Revert "Implement layout="zip" for Lambda/GCF, skipping lambdex" ([pantsbuild#19071](pantsbuild#19071)) * Remove unnecessary interpreter constraint config. ([pantsbuild#19065](pantsbuild#19065)) * Use hand-written change detection for PR/push job trimming ([pantsbuild#19045](pantsbuild#19045)) * Do not build wheels on push, since that is now accomplished by the release job. ([pantsbuild#19063](pantsbuild#19063)) * Additional release job publishing fixes ([pantsbuild#19058](pantsbuild#19058)) * Change CI trigger to includelist `main` and `2.*.x` ([pantsbuild#19059](pantsbuild#19059)) * Release doc and script fixes ([pantsbuild#19043](pantsbuild#19043)) * Update cherry-picker to use `pull_request_target` ([pantsbuild#19048](pantsbuild#19048)) * Prepare `2.16.0rc3`. ([pantsbuild#19044](pantsbuild#19044)) * Prepare `2.15.1`. ([pantsbuild#19042](pantsbuild#19042)) * Fixup welcome-newcomers.yaml ([pantsbuild#19039](pantsbuild#19039))

Internal changes: * Fix TypedDict construction ([#19166](#19166)) * Have package_dists.InvalidEntryPoint subclass InvalidFieldException ([#19149](#19149)) * Check for `CI=true`, not `CI=1` for cherry-picking ([#19141](#19141)) * Set up remote caching in CI ([#19144](#19144)) * refactor(internal): adjust pants_venv venv_dir calculation ([#19140](#19140)) * Prepare `2.16.0rc4`. ([#19146](#19146)) * Warn about `files()` in PEXes in one place ([#19027](#19027)) * Drop our explicit dep on `syn` ([#19134](#19134)) * Fix auto-cherry-picker's merge-conflicts ([#19125](#19125)) * Use explicit depths on fetches when running cherry-picks in CI ([#19127](#19127)) * Make determine_python() pin to 3.9 ([#19116](#19116)) * Upgrade to `actions/checkout@v3` ([#19112](#19112)) * Run the cherry pick script with `-x` for debugging ([#19095](#19095)) * Add more linux x86 test CI shards ([#19099](#19099)) * Use a trait for remote ByteStore network implementation ([#19050](#19050)) * Increase the logging of release version file publishing. ([#19092](#19092)) * Remove the Toolchain plugin ([#18978](#18978)) * Fix bad merge of #18829. ([#19080](#19080)) * Revert "Implement layout="zip" for Lambda/GCF, skipping lambdex" ([#19071](#19071)) * Remove unnecessary interpreter constraint config. ([#19065](#19065)) * Use hand-written change detection for PR/push job trimming ([#19045](#19045)) * Do not build wheels on push, since that is now accomplished by the release job. ([#19063](#19063)) * Additional release job publishing fixes ([#19058](#19058)) * Change CI trigger to includelist `main` and `2.*.x` ([#19059](#19059)) * Release doc and script fixes ([#19043](#19043)) * Update cherry-picker to use `pull_request_target` ([#19048](#19048)) * Prepare `2.16.0rc3`. ([#19044](#19044)) * Prepare `2.15.1`. ([#19042](#19042)) * Fixup welcome-newcomers.yaml ([#19039](#19039))

Only build wheels for Python 3.9.

342c5d6

benjyw added the category:user api change label Apr 24, 2023

benjyw requested review from jsirois, stuhood, kaos, Eric-Arellano and thejcannon April 24, 2023 23:59

Eric-Arellano approved these changes Apr 25, 2023

View reviewed changes

kaos approved these changes Apr 25, 2023

View reviewed changes

jsirois approved these changes Apr 25, 2023

View reviewed changes

Eric-Arellano mentioned this pull request Apr 26, 2023

Deprecate running Pants outside scie-pants. #18833

Merged

stuhood approved these changes Apr 26, 2023

View reviewed changes

benjyw merged commit 97784d0 into pantsbuild:main May 21, 2023
17 checks passed

benjyw deleted the only_release_py39_wheels branch May 21, 2023 15:28

benjyw mentioned this pull request May 21, 2023

Remove more 2.18.0.dev0 deprecations (follow up to #19073) #19077

Merged

benjyw added a commit to benjyw/pants that referenced this pull request May 21, 2023

Fix bad merge of pantsbuild#18829

bba2c83

benjyw added a commit to benjyw/pants that referenced this pull request May 21, 2023

Fix bad merge of #pantsbuild#18829.

78954f2

cognifloyd pushed a commit that referenced this pull request May 21, 2023

Fix bad merge of #18829. (#19080)

00b0eef

huonw mentioned this pull request May 23, 2023

Pants Daily extened testing breaks for python 3.9 & 3.8 #14427

Closed

illicitonion mentioned this pull request May 26, 2023

Prep 2.18.0.dev0 #19167

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Only build and release wheels for Python 3.9. #18829

Only build and release wheels for Python 3.9. #18829

benjyw commented Apr 24, 2023

Eric-Arellano left a comment

Eric-Arellano Apr 25, 2023

benjyw Apr 25, 2023

Eric-Arellano Apr 25, 2023

kaos Apr 25, 2023 •

edited

benjyw Apr 25, 2023

jsirois left a comment

jsirois commented Apr 25, 2023 •

edited

kaos commented Apr 25, 2023

benjyw commented Apr 25, 2023 •

edited

benjyw commented Apr 25, 2023

kaos commented Apr 25, 2023

benjyw commented Apr 25, 2023

benjyw commented May 21, 2023

thejcannon commented May 21, 2023

Only build and release wheels for Python 3.9. #18829

Only build and release wheels for Python 3.9. #18829

Conversation

benjyw commented Apr 24, 2023

Eric-Arellano left a comment

Choose a reason for hiding this comment

Eric-Arellano Apr 25, 2023

Choose a reason for hiding this comment

benjyw Apr 25, 2023

Choose a reason for hiding this comment

Eric-Arellano Apr 25, 2023

Choose a reason for hiding this comment

kaos Apr 25, 2023 • edited

Choose a reason for hiding this comment

benjyw Apr 25, 2023

Choose a reason for hiding this comment

jsirois left a comment

Choose a reason for hiding this comment

jsirois commented Apr 25, 2023 • edited

kaos commented Apr 25, 2023

benjyw commented Apr 25, 2023 • edited

benjyw commented Apr 25, 2023

kaos commented Apr 25, 2023

benjyw commented Apr 25, 2023

benjyw commented May 21, 2023

thejcannon commented May 21, 2023

kaos Apr 25, 2023 •

edited

jsirois commented Apr 25, 2023 •

edited

benjyw commented Apr 25, 2023 •

edited