javascript: Support Node.js subpath imports #18934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuhood
approved these changes
May 8, 2023
| @@ -110,8 +129,10 @@ async def infer_js_source_dependencies( | |||
| owning_targets = await Get(Targets, Addresses(owners)) | |||
|
|
|||
| non_path_string_bases = FrozenOrderedSet( | |||
| os.path.basename(non_path_string) for non_path_string in import_strings - path_strings | |||
| non_path_string.split(os.path.sep, 1)[0] | |||
There was a problem hiding this comment.
Nit: For split(.., 1), partition can be a little bit cleaner: https://docs.python.org/3/library/stdtypes.html#str.partition
|
|
||
| @staticmethod | ||
| def _to_import_pattern(string: str) -> re.Pattern[str]: | ||
| return re.compile(r"^" + re.escape(string).replace(r"\*", "(.*)")) |
There was a problem hiding this comment.
Are these supposed to match files recursively, or only within a directory? If the latter, you might want to use ([^/]*)?
There was a problem hiding this comment.
The '*' token is a string replacement token, not a glob. So I think the answer is the former statement is correct.
See https://nodejs.org/api/packages.html#subpath-patterns, specifically this bit
* maps expose nested subpaths as it is a string replacement syntax only.
tobni
force-pushed
the
add/support-subpath-imports
branch
from
b857162
to
386bc38
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for the inference impl to inspect
package.json#imports, and backwards map this object to find dependencies known by pants.Relevant part of Node.js docs: https://nodejs.org/api/packages.html#subpath-imports.