Fixup PythonTask chroot caching. #1915
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously there were a few issues that could lead to over-invalidation, but most importantly, there was an issue leading to under-invalidation. Fixup chroot target fingerprinting to be transitive, previously just the top-level targets were fingerprinted. This fixes under-invalidation based on changes to python chroot trabsitive target dependency edits. Also fixup unstable portions of the fingerprint with a few TODOs added to do these more cleanly. Add a PythonTaskTest that exercises these cases as well as the unchanged chroot case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously there were a few issues that could lead to over-invalidation,
but most importantly, there was an issue leading to under-invalidation.
Fixup chroot target fingerprinting to be transitive, previously just the
top-level targets were fingerprinted. This fixes under-invalidation
based on changes to python chroot trabsitive target dependency edits.
Also fixup unstable portions of the fingerprint with a few TODOs added
to do these more cleanly.
Add a PythonTaskTest that exercises these cases as well as the unchanged
chroot case.