Avoid extra . in from .. import parent imports in Rust Python dep inference
#19175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions bot
pushed a commit
that referenced
this pull request
May 28, 2023
… inference (#19175) This fixes #19173 by generalising the `from . import a` special case to also handle `from .. import a` etc.: _any_ module path that ends with a `.` doesn't need an extra `.` to separate the module path from the name(s). Before this fix, `from . import a` was special cased to avoid an extra dot (becoming `.a` as desired), while `from .. import a` was not special cased. It became `...a` (extra `.`), by joining the module path (`..`) and the name (`a`) with the usual `.` separator. This separator is only appropriate for normal names like `from x import a`.
huonw
added a commit
that referenced
this pull request
May 28, 2023
… inference (Cherry-pick of #19175) (#19177) This fixes #19173 by generalising the `from . import a` special case to also handle `from .. import a` etc.: _any_ module path that ends with a `.` doesn't need an extra `.` to separate the module path from the name(s). Before this fix, `from . import a` was special cased to avoid an extra dot (becoming `.a` as desired), while `from .. import a` was not special cased. It became `...a` (extra `.`), by joining the module path (`..`) and the name (`a`) with the usual `.` separator. This separator is only appropriate for normal names like `from x import a`. Co-authored-by: Huon Wilson <huon@exoflare.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #19173 by generalising the
from . import aspecial case to also handlefrom .. import aetc.: any module path that ends with a.doesn't need an extra.to separate the module path from the name(s).Before this fix,
from . import awas special cased to avoid an extra dot (becoming.aas desired), whilefrom .. import awas not special cased. It became...a(extra.), by joining the module path (..) and the name (a) with the usual.separator. This separator is only appropriate for normal names likefrom x import a.