store stdout/stderr output from tests as bytes #19184
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Pants expects test output to be in UTF-8 even though this assumption is not a valid to make given that test output comes from process invocations. As described in #19121, this causes a
UnicodeDecodeError
under the conditions mentioned there.Solution
Instead of storing a
str
, just store the binary output for stdout and stderr from the underlyingProcess
to avoid string encoding issues as much as possible. When creating a message for output, only then decode the stings as UTF-8 and replace invalid characters.The
stdout
andstderr
attributes are renamed tostdout_bytes
andstderr_bytes
, respectively, Introducestdout
andstderr
properties so that external plugins get a deprecation warning.Fixes #19121.