New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add style guide instructions for writing Python docstrings #19365
docs: add style guide instructions for writing Python docstrings #19365
Conversation
Is there anything that you think would be worth adding? |
74ebd4f
to
ee3bc17
Compare
ee3bc17
to
a2795f8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love that you're writing this. It'll be really nice to add to our dev docs. One big nit though.
You keep using "docstrings", but I think you mean "help strings". Docstrings are strings in specific places, that eventually become some objects __doc__
. These are just strings provided to functions.
Can you replace "docstrings" with "help strings"? Then, it's good to go from me. (And thanks again)
a2795f8
to
91c4e5a
Compare
Oh yes, indeed, this is a much better wording, 100% agreed. Fixed! |
Replaced "docstrings" with "help strings"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
Add some practical advice on how to edit the docstrings for the reference docs so that we could refer to this page when needed.