Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Visibility: fix issue with using target type in verbose rule selector. #19437

Merged
merged 3 commits into from Jul 13, 2023
Merged

Visibility: fix issue with using target type in verbose rule selector. #19437

merged 3 commits into from Jul 13, 2023

Conversation

kaos
Copy link
Member

@kaos kaos commented Jul 8, 2023

Fixes #19390

@kaos kaos added needs-cherrypick category:bugfix Bug fixes for released features labels Jul 8, 2023
@kaos kaos added this to the 2.16.x milestone Jul 8, 2023
@kaos kaos merged commit 9f49668 into main Jul 13, 2023
24 checks passed
@kaos kaos deleted the kaos/issue-19390 branch July 13, 2023 14:26
github-actions bot pushed a commit that referenced this pull request Jul 13, 2023
@kaos @WorkerPants
Visibility: fix issue with using target type in verbose rule selector. (
ebf85b3 
#19437)

Fixes #19390
github-actions bot pushed a commit that referenced this pull request Jul 13, 2023
@kaos @WorkerPants
Visibility: fix issue with using target type in verbose rule selector. (
ea737cb 
#19437)

Fixes #19390
@WorkerPants
Copy link
Member

I tried to automatically cherry-pick this change back to each relevant milestone, so that it is available in those older releases of Pants.

✔️ 2.16.x

Successfully opened #19457.

✔️ 2.17.x

Successfully opened #19456.

Thanks again for your contributions!

🤖 Beep Boop here's my run link

kaos added a commit that referenced this pull request Jul 14, 2023
@WorkerPants @kaos
Visibility: fix issue with using target type in verbose rule selector…
0120d51 
…. (Cherry-pick of #19437) (#19456)

Fixes #19390

Co-authored-by: Andreas Stenius <andreas.stenius@imanage.com>
kaos added a commit that referenced this pull request Jul 14, 2023
@WorkerPants @kaos
Visibility: fix issue with using target type in verbose rule selector…
f43c359 
…. (Cherry-pick of #19437) (#19457)

Fixes #19390

---------

Co-authored-by: Andreas Stenius <andreas.stenius@imanage.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thejcannon thejcannon thejcannon approved these changes

Assignees
No one assigned
Labels
category:bugfix Bug fixes for released features
Projects
None yet
Milestone
2.16.x
Development

Successfully merging this pull request may close these issues.

Can not use target type in visibility rule selector.
3 participants
@kaos @WorkerPants @thejcannon