Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add build platform and hosts options to docker_image target #19475

Merged
merged 3 commits into from Jul 19, 2023
Merged

Add build platform and hosts options to docker_image target #19475

merged 3 commits into from Jul 19, 2023

Conversation

riisi
Copy link
Contributor

@riisi riisi commented Jul 16, 2023

For #19350.

I plan to add the --no-cache option (global & for each image) next to complete that issue.

@riisi riisi requested a review from kaos July 16, 2023 09:22
@riisi riisi added category:new feature backend: Docker Docker backend-related issues and removed backend: Docker Docker backend-related issues labels Jul 16, 2023
kaos
kaos approved these changes Jul 16, 2023
View reviewed changes
Copy link
Member

@kaos kaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍🏽

I'm starting to get slightly confused with the various forms of build option mixin classes. Will soon be time to see if we can align them with some good refactorings now that we start to see some emerging patterns perhaps?

@riisi
Copy link
Contributor Author

riisi commented Jul 19, 2023

Nice 👍🏽

I'm starting to get slightly confused with the various forms of build option mixin classes. Will soon be time to see if we can align them with some good refactorings now that we start to see some emerging patterns perhaps?

I agree, it's hard to follow. Not super clear what would be optimal at this point, but worth keeping an eye on.

@kaos kaos merged commit 202daf8 into pantsbuild:main Jul 19, 2023
25 checks passed
@riisi riisi mentioned this pull request Aug 6, 2023
Merged
@huonw huonw mentioned this pull request Aug 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaos kaos kaos approved these changes

Assignees
No one assigned
Labels
category:new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@riisi @kaos