Add additional directories with register.py to pants bin deps (Cherry pick of #19848) #19855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I compared the output of `find . -name register.py` and the dependencies of the `src/python/pants/bin:plugins` target: this identified several backends that seemingly weren't being packaged into the Pants binary, and thus not available for users, similar to #19836. - `pants.backend.experimental.openapi.codegen.java` - `pants.backend.experimental.python.framework.django` - `pants.backend.experimental.swift` - `pants.backend.python.providers.experimental.pyenv.custom_install` Two of these (Django and Rust) also had minor issues the caused errors when being loaded, which this PR resolves. There were also two that have been upgraded from experimental to stable, that were depended upon via the old/deprecated experimental name, but not the stable name: - `pants.backend.python.lint.autoflake` - `pants.backend.python.lint.pyupgrade` This doesn't try to solve the problem of keeping this up to date. I can think of two approaches (definitely for a separate PR): - #17301, with a test that reads the `BUILD` file and compares the dependencies to a `find` for `register.py` files - a target that exposes the output of `pants peek ::` as a file, with a test that reads that file and does the appropriate validation
|
I'm not so sure about cherry-picking this back to be a patch release. |
|
Oh wait, I guess you ran this specifically on the 2.17.x branch? That makes sense. Nevermind me. Late morning 😅 |
thejcannon
approved these changes
Sep 18, 2023
kaos
approved these changes
Sep 18, 2023
I always wanted to make a |
Yeah, both |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I compared the output of
find . -name register.pyand the dependencies of thesrc/python/pants/bin:pluginstarget: this identified several backends that seemingly weren't being packaged into the Pants binary, and thus not available for users, similar to #19836.pants.backend.experimental.openapi.codegen.javapants.backend.experimental.python.framework.djangopants.backend.experimental.swiftpants.backend.python.providers.experimental.pyenv.custom_installDjango also had minor issues the caused errors when being loaded, which this PR resolves.
There were also two that have been upgraded from experimental to stable, that were depended upon via the old/deprecated experimental name, but not the stable name:
pants.backend.python.lint.autoflakepants.backend.python.lint.pyupgradeThis doesn't try to solve the problem of keeping this up to date. I can think of two approaches (definitely for a separate PR):
BUILDfile and compares the dependencies to afindforregister.pyfilespants peek ::as a file, with a test that reads that file and does the appropriate validation(This is a manually tailored cherry pick of #19848 to be appropriate for 2.17.)