Add exclude_files field to deploy_jar target
#20075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grihabor
changed the title
exclude_files field to deploy_jar target
auto-merge was automatically disabled
October 31, 2023 22:10
Head branch was pushed to by a user without write access
grihabor
force-pushed
the
add-exclude-files-field-to-deploy-jar-target
branch
from
753413c
to
8325b6c
Compare
WorkerPants
pushed a commit
that referenced
this pull request
Oct 31, 2023
I tried running `pants package :my_deploy_jar` and got this:
```
Exception in thread "main" java.lang.SecurityException: Invalid signature file digest for Manifest main attributes
```
To fix this issue I've added `exclude_files` field to `deploy_jar`
target, which allowed me to exclude jar signature:
```python
deploy_jar(
name="my_deploy_jar",
...,
exclude_files=["META-INF/*.SF", "META-INF/*.DSA", "META-INF/*.RSA"],
)
```
|
I tried to automatically cherry-pick this change back to each relevant milestone, so that it is available in those older releases of Pants. ✔️ 2.18.xSuccessfully opened #20126. Thanks again for your contributions! |
huonw
pushed a commit
that referenced
this pull request
Nov 1, 2023
…) (#20126) I tried running `pants package :my_deploy_jar` and got this: ``` Exception in thread "main" java.lang.SecurityException: Invalid signature file digest for Manifest main attributes ``` To fix this issue I've added `exclude_files` field to `deploy_jar` target, which allowed me to exclude jar signature: ```python deploy_jar( name="my_deploy_jar", ..., exclude_files=["META-INF/*.SF", "META-INF/*.DSA", "META-INF/*.RSA"], ) ``` Co-authored-by: Gregory Borodin <grihabor@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried running
pants package :my_deploy_jarand got this:To fix this issue I've added
exclude_filesfield todeploy_jartarget, which allowed me to exclude jar signature: