Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use fork of indicatif to work around output truncation #20269

Merged

Conversation

tgolsson
Copy link
Contributor

@tgolsson tgolsson commented Dec 6, 2023

Fixes #20171.

Upstream seems very slow on merging the fix so adding my fork. @lilatomic can you validate this also solves the problem on your end?

@kaos
Copy link
Member

kaos commented Dec 6, 2023

Linking the PRs here so it's easier to track when they're closed:
console-rs/console#186
console-rs/indicatif#608

@tgolsson tgolsson added the category:bugfix Bug fixes for released features label Dec 6, 2023
Copy link
Contributor

@lilatomic lilatomic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this solved it for me!

@tgolsson tgolsson added this to the 2.19.x milestone Dec 10, 2023
@tgolsson tgolsson merged commit 0be1104 into pantsbuild:main Dec 10, 2023
24 checks passed
@WorkerPants
Copy link
Member

I tried to automatically cherry-pick this change back to each relevant milestone, so that it is available in those older releases of Pants.

❌ 2.19.x

I was unable to cherry-pick this PR to 2.19.x, likely due to merge-conflicts.

Steps to Cherry-Pick locally

To resolve:

  1. (Ensure your git working directory is clean)
  2. Run the following script to reproduce the merge-conflicts:
    git fetch https://github.com/pantsbuild/pants main \
      && git fetch https://github.com/pantsbuild/pants 2.19.x \
      && git checkout -b cherry-pick-20269-to-2.19.x FETCH_HEAD \
      && git cherry-pick 0be110444160d512235f7f5409b6770873d60c2b
  3. Fix the merge conflicts and commit the changes
  4. Run build-support/cherry_pick/make_pr.sh "20269" "2.19.x"

Please note that I cannot re-run CI if a job fails. Please work with your PR approver(s) to re-run CI if necessary.


When you're done manually cherry-picking, please remove the needs-cherrypick label on this PR.

Thanks again for your contributions!

🤖 Beep Boop here's my run link

@WorkerPants WorkerPants added the auto-cherry-picking-failed Auto Cherry-Picking Failed label Dec 10, 2023
tgolsson added a commit to tgolsson/pants that referenced this pull request Dec 10, 2023
@tgolsson tgolsson deleted the ts/indicatif-test-output-truncation branch December 10, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-cherry-picking-failed Auto Cherry-Picking Failed category:bugfix Bug fixes for released features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test output is truncated
4 participants