Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix GitHub brand notation #20629

Merged
merged 2 commits into from
Feb 29, 2024
Merged

docs: Fix GitHub brand notation #20629

merged 2 commits into from
Feb 29, 2024

Conversation

Yaminyam
Copy link
Contributor

@Yaminyam Yaminyam commented Feb 29, 2024

During a release, the contents of this directory is synced with our website repo (https://github.com/pantsbuild/pantsbuild.org) to be deployed.
Does this mean it's okay to edit the docs file in either the pants repo or the pantsbuild.rog repo?

Copy link
Member

@kaos kaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Doc changes should be made to the pants repo, they are then synched over to the pantsbuild.org repo, so any changes there would be overwritten, iiuc.

@@ -43,7 +43,7 @@ function git_merge_base() {
# This prints the tracking branch if set and otherwise falls back to the commit before HEAD.
# We fall back to the commit before HEAD to attempt to account for situations without a tracking
# branch, which might include `main` builds, but can also include branch-PR builds, where
# Travis checks out a specially crafted Github `+refs/pull/11516/merge` branch.
# Travis checks out a specially crafted GitHub `+refs/pull/11516/merge` branch.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Travis..?!? Lol, this must be very old, and also a stale comment, as travis have not been used for years (before my time with the project).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

| Travis, Linux | 2 | 7.5 GB | [link](https://docs.travis-ci.com/user/reference/overview/#virtualisation-environment-vs-operating-system) |

Information about travis is also found elsewhere haha.

@kaos kaos enabled auto-merge (squash) February 29, 2024 10:21
@kaos kaos merged commit 1aed24f into pantsbuild:main Feb 29, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants