upgrade Rust to v1.78.0

.github/workflows/release.yaml

@@ -192,7 +192,7 @@ jobs:
       with:
         key: macOS10-15-x86_64-rustup-${{ hashFiles('src/rust/engine/rust-toolchain')
           }}-v2
-        path: '~/.rustup/toolchains/1.77.0-*
+        path: '~/.rustup/toolchains/1.78.0-*
 
           ~/.rustup/update-hashes
 
@@ -276,7 +276,7 @@ jobs:
       with:
         key: macOS11-ARM64-rustup-${{ hashFiles('src/rust/engine/rust-toolchain')
           }}-v2
-        path: '~/.rustup/toolchains/1.77.0-*
+        path: '~/.rustup/toolchains/1.78.0-*
 
           ~/.rustup/update-hashes
 
@@ -367,7 +367,7 @@ jobs:
       uses: actions/cache@v3
       with:
         key: Linux-x86_64-rustup-${{ hashFiles('src/rust/engine/rust-toolchain') }}-v2
-        path: '~/.rustup/toolchains/1.77.0-*
+        path: '~/.rustup/toolchains/1.78.0-*
 
           ~/.rustup/update-hashes
 

.github/workflows/test.yaml

@@ -38,7 +38,7 @@ jobs:
       uses: actions/cache@v3
       with:
         key: Linux-ARM64-rustup-${{ hashFiles('src/rust/engine/rust-toolchain') }}-v2
-        path: '~/.rustup/toolchains/1.77.0-*
+        path: '~/.rustup/toolchains/1.78.0-*
 
           ~/.rustup/update-hashes
 
@@ -130,7 +130,7 @@ jobs:
       uses: actions/cache@v3
       with:
         key: Linux-x86_64-rustup-${{ hashFiles('src/rust/engine/rust-toolchain') }}-v2
-        path: '~/.rustup/toolchains/1.77.0-*
+        path: '~/.rustup/toolchains/1.78.0-*
 
           ~/.rustup/update-hashes
 
@@ -232,7 +232,7 @@ jobs:
       uses: actions/cache@v3
       with:
         key: macOS11-x86_64-rustup-${{ hashFiles('src/rust/engine/rust-toolchain') }}-v2
-        path: '~/.rustup/toolchains/1.77.0-*
+        path: '~/.rustup/toolchains/1.78.0-*
 
           ~/.rustup/update-hashes
 
@@ -441,7 +441,7 @@ jobs:
       uses: actions/cache@v3
       with:
         key: macOS10-15-x86_64-rustup-${{ hashFiles('src/rust/engine/rust-toolchain') }}-v2
-        path: '~/.rustup/toolchains/1.77.0-*
+        path: '~/.rustup/toolchains/1.78.0-*
 
           ~/.rustup/update-hashes
 
@@ -508,7 +508,7 @@ jobs:
       uses: actions/cache@v3
       with:
         key: macOS11-ARM64-rustup-${{ hashFiles('src/rust/engine/rust-toolchain') }}-v2
-        path: '~/.rustup/toolchains/1.77.0-*
+        path: '~/.rustup/toolchains/1.78.0-*
 
           ~/.rustup/update-hashes
 

src/rust/engine/BUILD

@@ -11,7 +11,7 @@ files(
         "**/*.rs",
         "!**/*tests.rs",
         "**/*.proto",
-        ".cargo/config",
+        ".cargo/config.toml",
     ],
 )
 

src/rust/engine/hashing/src/lib.rs

@@ -351,13 +351,10 @@ impl<AW: ?Sized + AsyncWrite + Unpin> AsyncWrite for WriterHasher<&mut AW> {
 /// Copy the data from reader and hash the bytes in one pass.
 /// Use hash() to just hash without copying the data anywhere.
 ///
-pub fn sync_copy_and_hash<R: ?Sized, W: ?Sized>(
-    reader: &mut R,
-    writer: &mut W,
-) -> io::Result<Digest>
+pub fn sync_copy_and_hash<R, W>(reader: &mut R, writer: &mut W) -> io::Result<Digest>
 where
-    R: io::Read,
-    W: io::Write,
+    R: io::Read + ?Sized,
+    W: io::Write + ?Sized,
 {
     let mut hasher = WriterHasher::new(writer);
     let _ = io::copy(reader, &mut hasher)?;
@@ -367,15 +364,15 @@ where
 ///
 /// Copy from reader to writer and return whether the copied data matches expected_digest.
 ///
-pub fn sync_verified_copy<R: ?Sized, W: ?Sized>(
+pub fn sync_verified_copy<R, W>(
     expected_digest: Digest,
     data_is_immutable: bool,
     reader: &mut R,
     writer: &mut W,
 ) -> io::Result<bool>
 where
-    R: io::Read,
-    W: io::Write,
+    R: io::Read + ?Sized,
+    W: io::Write + ?Sized,
 {
     if data_is_immutable {
         // Trust that the data hasn't changed, and only validate its length.

src/rust/engine/process_execution/remote/src/remote.rs

@@ -211,7 +211,7 @@ impl CommandRunner {
         let capabilities_fut = async {
             let mut request = remexec::GetCapabilitiesRequest::default();
             if let Some(s) = self.instance_name.as_ref() {
-                request.instance_name = s.clone();
+                request.instance_name.clone_from(s);
             }
 
             let request = apply_headers(Request::new(request), "");

src/rust/engine/remote_provider/remote_provider_reapi/src/byte_store.rs

@@ -230,7 +230,7 @@ impl Provider {
         let capabilities_fut = async {
             let mut request = remexec::GetCapabilitiesRequest::default();
             if let Some(s) = self.instance_name.as_ref() {
-                request.instance_name = s.clone();
+                request.instance_name.clone_from(s);
             }
 
             let mut client = self.capabilities_client.as_ref().clone();

src/rust/engine/rule_graph/src/builder.rs

@@ -748,6 +748,8 @@ impl<R: Rule> Builder<R> {
                 minimal_in_set.insert(node_id);
 
                 // But we ensure that its out_set is accurate before continuing.
+                // Note: Clippy wants us to use `clone_from`, but doing so fails because `graph` is borrowed as mutable already.
+                #[allow(clippy::assigning_clones)]
                 if node.out_set != node.in_set {
                     graph.node_weight_mut(node_id).unwrap().0.out_set =
                         graph[node_id].0.in_set.clone();

src/rust/engine/rust-toolchain

@@ -1,5 +1,5 @@
 [toolchain]
-channel = "1.77.0"
+channel = "1.78.0"
 # NB: We don't list the components (namely `clippy` and `rustfmt`) and instead rely on either the
 #  the profile being "default" (by-and-large the default profile) or the nice error message from
 #  `cargo fmt` and `cargo clippy` if the required component isn't installed

src/rust/engine/src/python.rs

@@ -98,7 +98,6 @@ impl<'x> Params {
     }
 }
 
-///
 pub fn display_sorted_in_parens<T>(items: T) -> String
 where
     T: Iterator,