Scrooge gen: Cache resolved scrooge deps #3305
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current behavior is that we re-resolve the scrooge dependencies for each thrift target. This changes scrooge gen so that only the first target created does a resolve and afterwards it is cached.
stuhood
pushed a commit
that referenced
this pull request
May 15, 2016
The current behavior is that we re-resolve the scrooge dependencies for each thrift target. This changes scrooge gen so that only the first target created does a resolve and afterwards it is cached. Testing Done: CI away on PR. Local testing against code gen targets. Bugs closed: 3305 Reviewed at https://rbcommons.com/s/twitter/r/3790/ closes #3305
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current behavior is that we re-resolve the scrooge dependencies for each thrift target.
This changes scrooge gen so that only the first target created does a resolve and afterwards it is cached.