Javac selection #3733
Closed
Javac selection #3733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we always use the javac embedded in the JDK we're using to run zinc. This change supports experimenting with unreleased compiler versions without having to also build and run an unreleased, and possibly unstable, runtime, which would be a much riskier prospect. Specifically, this allows running the (relatively stable but still unreleased) javac 9 compiler on a Java 8 runtime, something that Bazel currently supports for various reasons. - Also remove a comment that was obsoleted long ago, in b15a7cb to be precise. - Also fix a couple of references to a non-public member of a base class.
Also address code review comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.