Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[engine] model snapshots in validation, make root rules a dict instead of a set #4125

Merged
merged 8 commits into from Dec 7, 2016
Merged

[engine] model snapshots in validation, make root rules a dict instead of a set #4125

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
baeb745
[engine] Rename NodeBuilder to RuleIndex, rm gen_nodes as it no longe…
baroquebobcat Dec 5, 2016
c270e12
port isolated process, rules and selector changes. May have more
baroquebobcat Dec 6, 2016
473cd87
more minor adjustments
baroquebobcat Dec 6, 2016
db278d6
more cleaning
baroquebobcat Dec 6, 2016
118229f
rm unused property declaration
baroquebobcat Dec 6, 2016
309e470
rm bad import
baroquebobcat Dec 7, 2016
c958a92
wasn't a bad import, was a missing dep in the build file
baroquebobcat Dec 7, 2016
0634954
The imported fn was moved, but I still had pyc files
baroquebobcat Dec 7, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/python/pants/engine/isolated_process.py
View file
Open in desktop
Expand Up @@ -199,7 +199,9 @@ def ptree(func):

def create_snapshot_intrinsics(project_tree):
def ptree(func):
return functools.partial(func, project_tree, snapshot_directory(project_tree))
partial = functools.partial(func, project_tree, snapshot_directory(project_tree))
partial.__name__ = '{}_intrinsic'.format(func.__name__)
return partial
return [
(Snapshot, Files, ptree(create_snapshot_archive)),
]
Expand All @@ -213,7 +215,9 @@ def create_snapshot_tasks(project_tree):
uncacheable singleton.
"""
def ptree(func):
return functools.partial(func, project_tree, snapshot_directory(project_tree))
partial = functools.partial(func, project_tree, snapshot_directory(project_tree))
partial.__name__ = '{}_task'.format(func.__name__)
return partial
return [
(Snapshot, [Select(Files)], ptree(create_snapshot_archive)),
]