Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Ensure that invalid vts have results_dir cleaned before passing to ta… #4139
Tasks that sometimes fail due to outside factors (download failures,
But since vt.results_dir is a symlink, that replaced it with a real dir.
This is a small change that deletes the existing directories if
The majority of the change is added test coverage around the breaks.
I am pushing this to CI to get Travis to take a crack at it - this will be my first non-release CR through github so forgive me if I muck the process at all.
You can read whenever you want, but I won't be adding specific reviewers until it passes CI.
ETA: I have two followups getting polished, one of which should also be backported to 1.2.1 (the error message for relative_symlink failure state)
Thanks Mateo... excellent work. Some minor nits, but not blocking probably.