Create a pants.init package. #4356

Merged
merged 1 commit into from Mar 23, 2017

Conversation

Projects
None yet
3 participants
@benjyw
Contributor

benjyw commented Mar 21, 2017

Provides some sanity to the dependencies of the init sequence:
previously they looped between packages, creating package-level,
and in some cases even target-level cycles.

Moves all code related to pants startup (options initialization,
plugin loading, daemon running etc.) to a single package.
Breaks up dependency cycles by passing a reference to
clean_global_runtime_state() into the PantsDaemon and a
reference to the pantsd launcher into the PantsDaemonKill
task (via the context).

@stuhood

This comment has been minimized.

Show comment
Hide comment
@stuhood

stuhood Mar 21, 2017

Member

Argh, sorry: I think this will be affected by 52e2648 having left the native_engine_version floating. Will fix with either #4340 or #4357

Member

stuhood commented Mar 21, 2017

Argh, sorry: I think this will be affected by 52e2648 having left the native_engine_version floating. Will fix with either #4340 or #4357

@benjyw

This comment has been minimized.

Show comment
Hide comment
@benjyw

benjyw Mar 21, 2017

Contributor
Contributor

benjyw commented Mar 21, 2017

@kwlzn

This comment has been minimized.

Show comment
Hide comment
@kwlzn

kwlzn Mar 22, 2017

Member

filed #4359 for it

Member

kwlzn commented Mar 22, 2017

filed #4359 for it

@benjyw benjyw requested a review from kwlzn Mar 22, 2017

Create a pants.init package.
Provides some sanity to the dependencies of the init sequence:
previously they looped between packages, creating package-level,
and in some cases even target-level cycles.

Moves all code related to pants startup (options initialization,
plugin loading, daemon running etc.) to a single package.
Breaks up dependency cycles by passing a reference to
clean_global_runtime_state() into the PantsDaemon and a
reference to the pantsd launcher into the PantsDaemonKill
task (via the context).
@benjyw

This comment has been minimized.

Show comment
Hide comment
@benjyw

benjyw Mar 23, 2017

Contributor

?

Sorry to nag, but I've got a tower of comments waiting on this one... And the sooner we can get on the new python pipeline the better, I reckon.

Contributor

benjyw commented Mar 23, 2017

?

Sorry to nag, but I've got a tower of comments waiting on this one... And the sooner we can get on the new python pipeline the better, I reckon.

@stuhood

This comment has been minimized.

Show comment
Hide comment
@stuhood

stuhood Mar 23, 2017

Member

Apologies... saw the iteration on CI, and wasn't sure it was ready. Looking.

Member

stuhood commented Mar 23, 2017

Apologies... saw the iteration on CI, and wasn't sure it was ready. Looking.

@stuhood

Looks great. Thank you!

@kwlzn

kwlzn approved these changes Mar 23, 2017

lgtm

@benjyw benjyw merged commit ba0994e into pantsbuild:master Mar 23, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@benjyw benjyw deleted the benjyw:fix_init_sequence_cycle branch Mar 23, 2017

lenucksi added a commit to lenucksi/pants that referenced this pull request Apr 25, 2017

Create a pants.init package. (#4356)
Provides some sanity to the dependencies of the init sequence:
previously they looped between packages, creating package-level,
and in some cases even target-level cycles.

Moves all code related to pants startup (options initialization,
plugin loading, daemon running etc.) to a single package.
Breaks up dependency cycles by passing a reference to
clean_global_runtime_state() into the PantsDaemon and a
reference to the pantsd launcher into the PantsDaemonKill
task (via the context).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment