Create a pants.init package. #4356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjyw
force-pushed
the
fix_init_sequence_cycle
branch
from
b167fda
to
e773bd3
Compare
|
This seems to happen a lot. Can we write a presubmit check for it?
…On Tue, Mar 21, 2017 at 2:50 PM, Stu Hood ***@***.***> wrote:
Argh, sorry: I think this will be affected by 52e2648
<52e2648>
having left the native_engine_version floating. Will fix with either #4340
<#4340> or #4357
<#4357>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#4356 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAfS_I8d79qBPcsEQ7MHMMhLjtOoGcNbks5roEYpgaJpZM4MkbBQ>
.
|
|
filed #4359 for it |
benjyw
force-pushed
the
fix_init_sequence_cycle
branch
2 times, most recently
from
04d430d
to
68c8b2e
Compare
Provides some sanity to the dependencies of the init sequence: previously they looped between packages, creating package-level, and in some cases even target-level cycles. Moves all code related to pants startup (options initialization, plugin loading, daemon running etc.) to a single package. Breaks up dependency cycles by passing a reference to clean_global_runtime_state() into the PantsDaemon and a reference to the pantsd launcher into the PantsDaemonKill task (via the context).
benjyw
force-pushed
the
fix_init_sequence_cycle
branch
from
68c8b2e
to
cafefc8
Compare
|
? Sorry to nag, but I've got a tower of comments waiting on this one... And the sooner we can get on the new python pipeline the better, I reckon. |
|
Apologies... saw the iteration on CI, and wasn't sure it was ready. Looking. |
stuhood
approved these changes
Mar 23, 2017
lenucksi
pushed a commit
to lenucksi/pants
that referenced
this pull request
Apr 25, 2017
Provides some sanity to the dependencies of the init sequence: previously they looped between packages, creating package-level, and in some cases even target-level cycles. Moves all code related to pants startup (options initialization, plugin loading, daemon running etc.) to a single package. Breaks up dependency cycles by passing a reference to clean_global_runtime_state() into the PantsDaemon and a reference to the pantsd launcher into the PantsDaemonKill task (via the context).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides some sanity to the dependencies of the init sequence:
previously they looped between packages, creating package-level,
and in some cases even target-level cycles.
Moves all code related to pants startup (options initialization,
plugin loading, daemon running etc.) to a single package.
Breaks up dependency cycles by passing a reference to
clean_global_runtime_state() into the PantsDaemon and a
reference to the pantsd launcher into the PantsDaemonKill
task (via the context).