New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make jar_library target export all its dependencies #4395
Changes from 5 commits
7c7b9ce
87cd814
a7ae0ee
1c784dd
3641367
24d0e8b
6c3791e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -25,3 +25,23 @@ scala_library( | |
dependencies=[':C'], | ||
strict_deps=True, | ||
) | ||
|
||
target( | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is there a test case that exercises this target here? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeah it's in tests/python/pants_test/backend/jvm/tasks/jvm_compile/test_dep_exports_integration.py. The test method does "list ::" in this dir, thus the new targets are automatically covered. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ah. I see. |
||
name='TB', | ||
dependencies=[':B'], | ||
) | ||
|
||
scala_library( | ||
name='TC', | ||
sources = ['C.scala'], | ||
dependencies=[':TB'], | ||
exports=[':TB'], | ||
strict_deps=True, | ||
) | ||
|
||
scala_library( | ||
name='TD', | ||
sources = ['D.scala'], | ||
dependencies=[':TC'], | ||
strict_deps=True, | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a test case for this bit of mutual recursion? It does make sense that it would work this way, but I'd like to see some examples.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, sure. I will add some unit tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added.