Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some compiler plugin documentation nits. #4462

Merged
merged 2 commits into from Apr 16, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Expand Up @@ -77,8 +77,8 @@ These are specified like this:
```
java_library(
...
javac_plugins: ['simple_javac_plugin'],
javac_plugin_args: {
javac_plugins=['simple_javac_plugin'],
javac_plugin_args={
'simple_javac_plugin': ['arg1', 'arg2']
}
)
Expand All @@ -88,6 +88,7 @@ java_library(

In order to load a plugin, it has to be on javac's classpath.
This can be achieved in one of two ways:

- Have targets that must be compiled with a plugin depend (directly or indirectly)
either on the `javac_plugin` target, or on a `jar_library` pointing to a published version
of the plugin.
Expand Down
Expand Up @@ -76,8 +76,8 @@ These are specified like this:
```
scala_library(
...
scalac_plugins: ['simple_scalac_plugin'],
scalac_plugin_args: {
scalac_plugins=['simple_scalac_plugin'],
scalac_plugin_args={
'simple_scalac_plugin': ['arg1', 'arg2']
}
)
Expand All @@ -87,6 +87,7 @@ scala_library(

In order to load a plugin, it has to be on scalac's classpath.
This can be achieved in one of two ways:

- Have targets that must be compiled with a plugin depend (directly or indirectly)
either on the `scalac_plugin` target, or on a `jar_library` pointing to a published version
of the plugin.
Expand Down
2 changes: 1 addition & 1 deletion src/python/pants/backend/jvm/subsystems/java.py
Expand Up @@ -36,7 +36,7 @@ def register_options(cls, register):

register('--compiler-plugin-deps', advanced=True, type=list, member_type=target_option,
removal_version='1.5.0.dev0',
removal_hint='Use --compile-zinc-javac-plugin-deps instead.',
removal_hint='See http://www.pantsbuild.org/javac_plugins.html#depending-on-plugins.',
fingerprint=True)

@classmethod
Expand Down