Add support for 'deployable_archives' for go and cpp rules. #4518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuhood
approved these changes
Apr 27, 2017
| @@ -49,7 +51,8 @@ def execute(self): | |||
| self._go_install(vt.target, gopath) | |||
| if self.is_binary(vt.target): | |||
| binary_path = os.path.join(gopath, 'bin', os.path.basename(vt.target.address.spec_path)) | |||
| self.context.products.get_data('exec_binary')[vt.target] = binary_path | |||
| go_exec_binary[vt.target] = binary_path | |||
| go_deployable_archive.add(vt.target, os.path.dirname(binary_path)).append(os.path.basename(binary_path)) | |||
There was a problem hiding this comment.
This pattern (explicitly calling basename) seems less error prone than what you're doing for cpp, which could likely be missed in a refactor.
There was a problem hiding this comment.
Done. I hope you can encapsulate this in the the new API. Like instead writing:
self.context.add_product_mapping('deployable_archives', vt.target, binary_path)
or something along the lines
There was a problem hiding this comment.
Even better than that, we hope! =)
This product_type is already used by java and python rules. Fixes #4506
|
Thanks for the patch! |
thesamet
pushed a commit
to thesamet/pants
that referenced
this pull request
May 9, 2017
…ld#4518) ### Problem Tasks need a canonical way to depend on executables. ### Solution Add support for the `deployable_archives` product-type to `go` and `cpp` rules, which is already used by the `java` and `python` rules. The mapping stores the executable name keyed under target and path, like done in the `java`/`python` rules. Fixes pantsbuild#4506.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This product_type is already used by java and python rules.
Fixes #4506
Problem
Tasks need a canonical way to depend on executables. See #4506
Solution
Add support for the 'deployable_archives' product-type to go and cpp rules. The mapping stores the executable name keyed under target and path, like done in the python/java rules.