Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch default binary-baseurls to s3 #4806

Merged
merged 2 commits into from Aug 9, 2017
Merged

Switch default binary-baseurls to s3 #4806

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
45cb5e3
Now that all artifacts have been migrated, switch binary_util to s3 b…
stuhood Aug 9, 2017
387b9b7
Remove old reference.
stuhood Aug 9, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 0 additions & 3 deletions contrib/node/examples/src/node/preinstalled-project/BUILD
View file
Open in desktop
Expand Up @@ -3,9 +3,6 @@

node_preinstalled_module(
sources=globs('package.json', 'src/*.js', 'test/*.js'),
# TODO(John Sirois): Update https://github.com/pantsbuild/node-preinstalled-modules to have a
# `sync-s3.sh` in place of the current `sync-bintray.sh`.
# See: https://github.com/pantsbuild/pants/issues/4800
dependencies_archive_url=
'https://s3.amazonaws.com/node-preinstalled-modules.pantsbuild.org/node_modules.tar.gz'
)
Expand Down
2 changes: 1 addition & 1 deletion src/python/pants/binaries/binary_util.py
View file
Open in desktop
Expand Up @@ -55,7 +55,7 @@ class Factory(Subsystem):
@classmethod
def register_options(cls, register):
register('--baseurls', type=list, advanced=True,
default=['https://dl.bintray.com/pantsbuild/bin/build-support'],
default=['https://s3.amazonaws.com/binaries.pantsbuild.org'],
help='List of urls from which binary tools are downloaded. Urls are searched in '
'order until the requested path is found.')
register('--fetch-timeout-secs', type=int, default=30, advanced=True,
Expand Down