Mention name of binary we can't find #4947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
illicitonion
force-pushed
the
dwagnerhall/findbinaryerror
branch
from
32d0c54
to
5db5137
Compare
This gives better debugging information for what went wrong.
illicitonion
force-pushed
the
dwagnerhall/findbinaryerror
branch
from
5db5137
to
a844e3d
Compare
kwlzn
reviewed
Oct 6, 2017
| .format(os_id)) | ||
| raise self.MissingMachineInfo(('Unable to find binary {name} version {version}. ' + | ||
| 'Update --binaries-path-by-id to find binaries for {os_id!r}') | ||
| .format(name=name, version=version, os_id=os_id)) |
There was a problem hiding this comment.
thanks to python's implicit string concatenation, you don't need the + or extra ()'s here:
>>> ('this is '
... 'an implicitly concatenated string '
... 'that can be formatted: {}'
... .format('see'))
'this is an implicitly concatenated string that can be formatted: see'
There was a problem hiding this comment.
I really dislike implicit string concatenation :(
Done.
| @@ -165,7 +165,7 @@ def uname_func(): | |||
|
|
|||
| with self.assertRaisesRegexp(BinaryUtil.MissingMachineInfo, | |||
| r'Pants has no binaries for vms'): | |||
| binary_util._select_binary_base_path("supportdir", "name", "version", uname_func=uname_func) | |||
| binary_util._select_binary_base_path("supportdir", "version", "name", uname_func=uname_func) | |||
There was a problem hiding this comment.
should all of the other callsites for _select_binary_base_path in this file invert name<->version too?
that seems to be the method signature:
def _select_binary_base_path(self, supportdir, version, name, uname_func=None):
so it's puzzling why other tests in this file pass them in the wrong order.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gives better debugging information for what went wrong.