Add pantsd client profiling #5434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
illicitonion
approved these changes
Feb 5, 2018
|
Unrelated contrib failure. Merging. |
benjyw
reviewed
Feb 5, 2018
stuhood
pushed a commit
that referenced
this pull request
Feb 5, 2018
### Problem As discovered in #5433, our current profiling does not cover an important case: the client in a `pantsd` session. ### Solution Add another profiling entrypoint to cover an entire client session with `pantsd` enabled, and document the options.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
As discovered in #5433, our current profiling does not cover an important case: the client in a
pantsdsession.Solution
Add another profiling entrypoint to cover an entire client session with
pantsdenabled, and document the options.