Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete unused old python pipeline classes. #5509

Merged
merged 1 commit into from Feb 23, 2018
Merged

Delete unused old python pipeline classes. #5509

merged 1 commit into from Feb 23, 2018

Conversation

benjyw
Copy link
Sponsor Contributor

@benjyw benjyw commented Feb 23, 2018

RIP PythonTask, PythonChroot, PythonAntlrBuilder, PythonThriftBuilder.

@benjyw
Delete unused old python pipeline classes.
99264cf 
RIP PythonTask, PythonChroot, PythonAntlrBuilder, PythonThriftBuilder.
@benjyw
Copy link
Sponsor Contributor Author

benjyw commented Feb 23, 2018

Removes 981 lines, adds 0. Very satisfying!

stuhood
stuhood approved these changes Feb 23, 2018
View reviewed changes
Copy link
Sponsor Member

@stuhood stuhood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahhh.

@benjyw benjyw merged commit 026aa74 into pantsbuild:master Feb 23, 2018
@benjyw benjyw deleted the kill_old_python_builders2 branch February 23, 2018 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stuhood stuhood stuhood approved these changes

@kwlzn kwlzn kwlzn approved these changes

@jsirois jsirois Awaiting requested review from jsirois

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@benjyw @stuhood @kwlzn