New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run scalafix before scalafmt #6011

Merged
merged 2 commits into from Jun 23, 2018

Conversation

Projects
None yet
2 participants
@wisechengyi
Copy link
Contributor

wisechengyi commented Jun 23, 2018

Fixes #6009

@stuhood
Copy link
Member

stuhood left a comment

Did you want this cherry-picked to 1.8.x?

@@ -217,7 +217,7 @@ def register_goals():

# Formatting.
task(name='scalafmt', action=ScalaFmtFormat, serialize=False).install('fmt')
task(name='scalafix', action=ScalaFixFix).install('fmt')
task(name='scalafix', action=ScalaFixFix).install(goal='fmt', before='scalafmt')

This comment has been minimized.

@stuhood

stuhood Jun 23, 2018

Member

Could also just reorder these lines. But this is fine too!

This comment has been minimized.

@wisechengyi

wisechengyi Jun 23, 2018

Contributor

oh duh! haha how did i miss that? I will just reverse them.

If there is other issue to cherry pick, then might as well. Otherwise waiting for 1.9.x is good too.

This comment has been minimized.

@stuhood

stuhood Jun 23, 2018

Member

Picked it.

@wisechengyi wisechengyi merged commit f7e21eb into pantsbuild:master Jun 23, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@wisechengyi wisechengyi deleted the wisechengyi:scalafix_first branch Jun 23, 2018

@stuhood stuhood added this to the 1.8.x milestone Jun 23, 2018

stuhood added a commit that referenced this pull request Jun 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment