New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port errorprone to py3 #6118

Merged
merged 3 commits into from Jul 15, 2018

Conversation

Projects
None yet
2 participants
@GoingTharn
Copy link
Contributor

GoingTharn commented Jul 13, 2018

Problem

update to py3.

Solution

Only manual change:
-- targets = filter(self._is_errorprone_target, self.context.target_roots)
++ targets = [t for t in self.context.target_roots if self._is_errorprone_target(t)]

@stuhood
Copy link
Member

stuhood left a comment

Thanks!

@GoingTharn GoingTharn changed the title change filter to list comp Port errorprone to py3 Jul 13, 2018

GoingTharn and others added some commits Jul 13, 2018

@stuhood stuhood merged commit 35f7873 into pantsbuild:master Jul 15, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment