Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port errorprone to py3 #6118

Merged
merged 3 commits into from Jul 15, 2018
Merged

Conversation

GoingTharn
Copy link
Contributor

@GoingTharn GoingTharn commented Jul 13, 2018

Problem

update to py3.

Solution

Only manual change:
-- targets = filter(self._is_errorprone_target, self.context.target_roots)
++ targets = [t for t in self.context.target_roots if self._is_errorprone_target(t)]

Copy link
Sponsor Member

@stuhood stuhood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@GoingTharn GoingTharn changed the title change filter to list comp Port errorprone to py3 Jul 13, 2018
@stuhood stuhood merged commit 35f7873 into pantsbuild:master Jul 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants