New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare a noop release for 1.9.0rc1. #6204

Merged
merged 6 commits into from Jul 20, 2018

Conversation

Projects
None yet
4 participants
@cosmicexplorer
Copy link
Contributor

cosmicexplorer commented Jul 20, 2018

Problem

Trying to release 1.9.0rc0 failed, and pypi won't accept another release to the same version. #6192 will have more information about what happened here after we can get this release out.

Solution

Make a noop release for 1.9.0rc1.

Result

We finally have a release candidate for 1.9.0. I plan to fast-follow with a hotfix release rc2 containing the changes from both #6201 and #6179, as these both describe bugged functionality that would make it very difficult to use python_dist() and the new C/C++ targets.

cosmicexplorer added some commits Jul 19, 2018

@cosmicexplorer cosmicexplorer requested review from stuhood , jsirois and kwlzn Jul 20, 2018

@@ -4,7 +4,12 @@ Master Pre-Releases
This document describes ``dev`` releases which occur weekly from master, and which do
not undergo the vetting associated with ``stable`` releases.

1.9.0rc0 (07/18/2018)
1.9.0rc1 (07/20/2018)

This comment has been minimized.

@stuhood

stuhood Jul 20, 2018

Member

This won't be release from master, so no edits needed in master.rst.

This comment has been minimized.

@cosmicexplorer

cosmicexplorer Jul 20, 2018

Contributor

Removed the 1.9.0rc1 entry from master.rst in d3b5d9d!

This comment has been minimized.

@wisechengyi

wisechengyi Jul 20, 2018

Contributor

Did we change the process recently? iirc, the notes still needs to be on master.

This comment has been minimized.

@wisechengyi

wisechengyi Jul 20, 2018

Contributor

oh nvm. master.rst doesn't need to change.

1.9.0rc1 (07/20/2018)
---------------------

*1.9.0rc0 failed due to a pypi error -- see `Issue 6192 <https://github.com/pantsbuild/pants/issues/6192>`.*

This comment has been minimized.

@wisechengyi

wisechengyi Jul 20, 2018

Contributor

Not sure how that renders, but using the normal format would be fine.

This comment has been minimized.

@cosmicexplorer

cosmicexplorer Jul 20, 2018

Contributor

Fixed in 8ac01f1!

@@ -1 +1 @@
1.9.0rc0
1.9.0rc1

This comment has been minimized.

@wisechengyi

wisechengyi Jul 20, 2018

Contributor

Please leave this unchanged. This PR would land on master, so the diff to change version to 1.9.0rc1 should land on the 1.9.x branch separately.

This comment has been minimized.

@cosmicexplorer

cosmicexplorer Jul 20, 2018

Contributor

Got it. I will make that change to the 1.9.x branch, which I will create now. The change was reverted in d46f679.

This comment has been minimized.

cosmicexplorer added some commits Jul 20, 2018

@wisechengyi
Copy link
Contributor

wisechengyi left a comment

Thanks Danny!

@cosmicexplorer cosmicexplorer merged commit 503c377 into pantsbuild:master Jul 20, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

cosmicexplorer added a commit that referenced this pull request Jul 20, 2018

Prepare a noop release for 1.9.0rc1. (#6204)
### Problem

Trying to release `1.9.0rc0` failed, and pypi won't accept another release to the same version. #6192 will have more information about what happened here after we can get this release out.

### Solution

Make a noop release for `1.9.0rc1`.

### Result

We finally have a release candidate for 1.9.0. I plan to fast-follow with a hotfix release `rc2` containing the changes from both #6201 and #6179, as these both describe bugged functionality that would make it very difficult to use `python_dist()` and the new C/C++ targets.

CMLivingston pushed a commit to CMLivingston/pants that referenced this pull request Aug 27, 2018

Prepare a noop release for 1.9.0rc1. (pantsbuild#6204)
### Problem

Trying to release `1.9.0rc0` failed, and pypi won't accept another release to the same version. pantsbuild#6192 will have more information about what happened here after we can get this release out.

### Solution

Make a noop release for `1.9.0rc1`.

### Result

We finally have a release candidate for 1.9.0. I plan to fast-follow with a hotfix release `rc2` containing the changes from both pantsbuild#6201 and pantsbuild#6179, as these both describe bugged functionality that would make it very difficult to use `python_dist()` and the new C/C++ targets.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment