Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Process execution: Create symlink to JDK on demand #6346

Merged
merged 2 commits into from Aug 14, 2018
Merged

Process execution: Create symlink to JDK on demand #6346

merged 2 commits into from Aug 14, 2018

Commits on Aug 14, 2018

  1. Process execution: Create symlink to JDK on demand 

    This creates a symlink `.jdk` pointing at the passed JDK, if one was
passed.

This is a hack to allow for a remote execution platform to provide a
pointer at its pre-installed JDK without needing to pollute absolute
paths into the action definition.

Long-term, we want the JDK to be part of the input directory for the
action, but that's a lot of work, and we want to experiment with
pre-installed JDKs in the mean time.
    @illicitonion
    illicitonion committed Aug 14, 2018
    Copy the full SHA
    89ba860 View commit details
    Browse the repository at this point in the history

  2. Use empty string for None 

    Before, None would become the string 'None', which isn't what anyone wants
    @illicitonion
    illicitonion committed Aug 14, 2018
    Copy the full SHA
    9fe82ae View commit details
    Browse the repository at this point in the history