Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow pex download path to be overridden #6348

Merged
merged 1 commit into from Aug 15, 2018
Merged

Allow pex download path to be overridden #6348

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 4 additions & 1 deletion build-support/bin/release.sh
View file
Open in desktop
Expand Up @@ -32,6 +32,9 @@ readonly DEPLOY_PANTS_WHEEL_DIR="${DEPLOY_DIR}/${DEPLOY_PANTS_WHEELS_PATH}"
# only pants core is included.
: ${PANTS_PEX_PACKAGES:="pantsbuild.pants"}

# URL from which pex release binaries can be downloaded.
: ${PEX_DOWNLOAD_PREFIX:="https://github.com/pantsbuild/pex/releases/download"}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this poking a hole for Twitter? It's probably harmless and I can't suggest a positive alternative solution but I will continue to point out its not awesome having to make private utility scripts support public apis. The pants script still has WRAPPER_REQUIREMENTS and WRAPPER_SRCPATH which may or may not still be used and at one point served similarly.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this is a hole for twitter; we want to be able to run release.sh -w in a locked down network, and sadly github releases are hosted on an unpredictable CDN :(


source ${ROOT}/contrib/release_packages.sh

function find_pkg() {
Expand Down Expand Up @@ -601,7 +604,7 @@ function build_pex() {
cd $(mktemp -d -t build_pex.XXXXX)
trap "rm -rf $(pwd -P)" EXIT

curl -sSL https://github.com/pantsbuild/pex/releases/download/v${PEX_VERSION}/${PEX_PEX} -O
curl -sSL "${PEX_DOWNLOAD_PREFIX}/v${PEX_VERSION}/${PEX_PEX}" -O
chmod +x ./${PEX_PEX}

./${PEX_PEX} \
Expand Down