Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle RPC errors as well as message-inline errors #6589

Merged
merged 3 commits into from Oct 5, 2018
Merged

Handle RPC errors as well as message-inline errors #6589

merged 3 commits into from Oct 5, 2018

Commits on Oct 3, 2018

  1. Handle RPC errors as well as message-inline errors 

    This required a minor change to grpcio
(pantsbuild/grpc-rs@4dfafe9)
to not throw away the information from the grpc stack.
    @illicitonion
    illicitonion committed Oct 3, 2018
    Copy the full SHA
    e636923 View commit details
    Browse the repository at this point in the history

  2. Add ignored test 

    Doesn't work right now because servers can't fail with a Status
    @illicitonion
    illicitonion committed Oct 3, 2018
    Copy the full SHA
    48921be View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2018

  1. Review comments

    @illicitonion
    illicitonion committed Oct 5, 2018
    Copy the full SHA
    4704bef View commit details
    Browse the repository at this point in the history