New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the release script. #6629

Merged
merged 2 commits into from Oct 14, 2018

Conversation

Projects
None yet
3 participants
@benjyw
Copy link
Contributor

benjyw commented Oct 14, 2018

The latest version of wheel (0.32.1, just released) no longer writes
the metadata.json file (see pypa/wheel#195).
Instead, we must now read the version from the METADATA file.

This change also tightens up the release docs a bit.

Fix the release script.
The latest version of wheel (0.32.1, just released) no longer writes
the metadata.json file (see pypa/wheel#195).
Instead, we must now read the version from the METADATA file.

This change also tightens up the release docs a bit.

@benjyw benjyw requested review from stuhood and jsirois Oct 14, 2018

@stuhood
Copy link
Member

stuhood left a comment

Thanks.

input_version = metadata['version']
# Get version from the input whl's metadata.
input_version = None
metadata_file = os.path.join(workspace, dist_info_dir, 'METADATA')

This comment has been minimized.

@stuhood

stuhood Oct 14, 2018

Member

Is there value in continuing to support rewriting both formats?

This comment has been minimized.

@benjyw

benjyw Oct 14, 2018

Contributor

Well, this is just where we get the original, qualified, version from. And the METADATA file is part of the wheel spec , so it was always OK to get the version from there.

@@ -730,7 +730,7 @@ elif [[ "${test_release}" == "true" ]]; then
else
banner "Releasing packages to PyPi" && \
(
check_origin && check_clean_branch && check_pgp && check_owners && \

This comment has been minimized.

@benjyw

benjyw Oct 14, 2018

Contributor

Ooops yes, that was sloppy. In my defense, it was Saturday night...

@jsirois

This comment has been minimized.

Copy link
Member

jsirois commented Oct 14, 2018

We shouldn't be hitting wheel 0.32.1 since pex is broken under that and pants pins to 0.31.1. From my phone, so lazy question: did you determine how 0.32.1 was entering the picture at all? That seems like a bug.

@benjyw

This comment has been minimized.

Copy link
Contributor

benjyw commented Oct 14, 2018

Turns out I was wrong about the underlying version that caused this - metadata.json was already removed in 0.31. I just noticed that 0.32.1 was published a few days ago, but the change to upgrade from 0.29 to 0.31.1 was also since the last release, so the former was a red herring.

@pantsbuild pantsbuild deleted a comment from stuhood Oct 14, 2018

@@ -730,7 +730,7 @@ elif [[ "${test_release}" == "true" ]]; then
else
banner "Releasing packages to PyPi" && \
(
check_origin && check_clean_branch && check_pgp && check_owners && \

This comment has been minimized.

@benjyw

benjyw Oct 14, 2018

Contributor

Ooops yes, that was sloppy. In my defense, it was Saturday night...

@jsirois

This comment has been minimized.

Copy link
Member

jsirois commented Oct 14, 2018

Aha, ok. I have on my list killing this version mangling since setuptools supports it natively. I think I have my cue to resume and kill this code.

@benjyw benjyw merged commit 0f80c70 into pantsbuild:master Oct 14, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@benjyw benjyw deleted the benjyw:fix_release branch Oct 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment