Make PailgunServer multithreaded in order to avoid blocking the PailgunService thread. #6669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…unService thread for long periods.
jsirois
approved these changes
Oct 22, 2018
|
|
||
| # Override the ThreadingMixIn default, to minimize the chances of zombie pailgun processes. | ||
| daemon_threads = True | ||
| timeout = 0.05 |
There was a problem hiding this comment.
Perhaps order the timeout line above the comment to make it clear the timeout applies to just the daemon_threads line.
stuhood
pushed a commit
that referenced
this pull request
Oct 29, 2018
…unService thread. (#6669) * Make PailgunServer multithreaded in order to avoid blocking the PailgunService thread for long periods.
stuhood
pushed a commit
that referenced
this pull request
Oct 29, 2018
…unService thread. (#6669) * Make PailgunServer multithreaded in order to avoid blocking the PailgunService thread for long periods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.