New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make PailgunServer multithreaded in order to avoid blocking the PailgunService thread. #6669

Merged
merged 2 commits into from Oct 24, 2018

Conversation

Projects
None yet
2 participants
@stuhood
Member

stuhood commented Oct 22, 2018

No description provided.

# Override the ThreadingMixIn default, to minimize the chances of zombie pailgun processes.
daemon_threads = True
timeout = 0.05

This comment has been minimized.

@jsirois

jsirois Oct 22, 2018

Member

Perhaps order the timeout line above the comment to make it clear the timeout applies to just the daemon_threads line.

@stuhood stuhood merged commit e5f2732 into pantsbuild:master Oct 24, 2018

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@stuhood stuhood deleted the twitter:stuhood/make-pailgunserver-multithreaded branch Oct 24, 2018

stuhood added a commit that referenced this pull request Oct 29, 2018

Make PailgunServer multithreaded in order to avoid blocking the Pailg…
…unService thread. (#6669)

* Make PailgunServer multithreaded in order to avoid blocking the PailgunService thread for long periods.

stuhood added a commit that referenced this pull request Oct 29, 2018

Make PailgunServer multithreaded in order to avoid blocking the Pailg…
…unService thread. (#6669)

* Make PailgunServer multithreaded in order to avoid blocking the PailgunService thread for long periods.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment