New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert release.sh from bash to python [part 1] #6674

Merged
merged 18 commits into from Oct 24, 2018

Conversation

Projects
None yet
5 participants
@wisechengyi
Contributor

wisechengyi commented Oct 23, 2018

Convert list_prebuilt_wheels and fetch_prebuilt_wheels to python.

Same logic + parallel downloading in python.

For #5551

wisechengyi added some commits Oct 22, 2018

fmt
fmt

@wisechengyi wisechengyi changed the title from [wip] slowly convert release.sh from bash to python to [wip] Incrementally convert release.sh from bash to python Oct 23, 2018

@wisechengyi wisechengyi force-pushed the wisechengyi:5551 branch from 3c1786a to 298e3ec Oct 23, 2018

@wisechengyi wisechengyi changed the title from [wip] Incrementally convert release.sh from bash to python to [wip] Incrementally convert release.sh from bash to python [part 1] Oct 23, 2018

@wisechengyi wisechengyi changed the title from [wip] Incrementally convert release.sh from bash to python [part 1] to Incrementally convert release.sh from bash to python [part 1] Oct 23, 2018

@wisechengyi wisechengyi changed the title from Incrementally convert release.sh from bash to python [part 1] to Convert release.sh from bash to python [part 1] Oct 23, 2018

@wisechengyi wisechengyi requested review from stuhood and illicitonion Oct 23, 2018

@wisechengyi

This comment has been minimized.

Contributor

wisechengyi commented Oct 23, 2018

This is ready for review. Thanks.

@Eric-Arellano

While I don't know the whole context, this looks like a great project! Python scripts are much easier to maintain and extend than Bash.

Show resolved Hide resolved src/python/pants/releases/release.py

@wisechengyi wisechengyi requested a review from dotordogh Oct 23, 2018

fmt

@wisechengyi wisechengyi requested review from jsirois and removed request for stuhood Oct 23, 2018

wisechengyi added some commits Oct 23, 2018

@baroquebobcat

Thanks for this.

Wow, fire looks really cool!

Show resolved Hide resolved src/python/pants/releases/release.py Outdated
Show resolved Hide resolved src/python/pants/releases/release.py Outdated
Show resolved Hide resolved src/python/pants/releases/release.py
@jsirois

This comment has been minimized.

Member

jsirois commented Oct 23, 2018

I'm all in favor of converting release to a language we can reasonably test, so I won't block. That said - this is all a bit simpler perhaps on the prod side using boto3, but definitely on the testing side using moto. Consider tests in a follow-up, and when doing so, consider switching to boto since it does support parallel transfers and convenient testing via moto.

@wisechengyi

This comment has been minimized.

Contributor

wisechengyi commented Oct 23, 2018

Thanks for the recs, John!

@wisechengyi

This comment has been minimized.

Contributor

wisechengyi commented Oct 24, 2018

Going to land this by EOD if there is no further comments.

@stuhood

Thanks Yi!

Show resolved Hide resolved src/python/pants/releases/release.py Outdated
Show resolved Hide resolved src/python/pants/releases/release.py

@wisechengyi wisechengyi merged commit 01c807e into pantsbuild:master Oct 24, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@wisechengyi wisechengyi deleted the wisechengyi:5551 branch Oct 24, 2018

wisechengyi added a commit to wisechengyi/pants that referenced this pull request Oct 29, 2018

wisechengyi added a commit that referenced this pull request Oct 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment