New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert release.sh from bash to python [part 1] #6674
Conversation
This is ready for review. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While I don't know the whole context, this looks like a great project! Python scripts are much easier to maintain and extend than Bash.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this.
Wow, fire looks really cool!
I'm all in favor of converting release to a language we can reasonably test, so I won't block. That said - this is all a bit simpler perhaps on the prod side using |
Thanks for the recs, John! |
Going to land this by EOD if there is no further comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Yi!
)" This reverts commit 01c807e.
Convert
list_prebuilt_wheels
andfetch_prebuilt_wheels
to python.Same logic + parallel downloading in python.
For #5551