New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buffer downloads in memory not on disk #6746

Merged
merged 1 commit into from Nov 12, 2018

Conversation

Projects
None yet
4 participants
@illicitonion
Contributor

illicitonion commented Nov 8, 2018

No description provided.

@illicitonion illicitonion requested review from stuhood and blorente Nov 8, 2018

@stuhood

stuhood approved these changes Nov 9, 2018

Looks great, thanks!

@@ -100,6 +101,7 @@ def create_scheduler(rules, validate=True, native=None):
native,
FileSystemProjectTree(os.getcwd()),
'./.pants.d',
safe_mkdtemp(),

This comment has been minimized.

@stuhood

stuhood Nov 9, 2018

Member

Is this a good default? Or do we want to default to the usual/global directory unless it's been overridden?

@ity

ity approved these changes Nov 9, 2018

@illicitonion illicitonion force-pushed the twitter:dwagnerhall/v2/urlfetch-cache branch from 189e59d to 653e279 Nov 12, 2018

@illicitonion illicitonion force-pushed the twitter:dwagnerhall/v2/urlfetch-cache branch from 653e279 to e197e93 Nov 12, 2018

@illicitonion illicitonion changed the title from Url fetch improvements to Buffer downloads in memory not on disk Nov 12, 2018

@illicitonion illicitonion merged commit 7ed40b2 into pantsbuild:master Nov 12, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@illicitonion illicitonion deleted the twitter:dwagnerhall/v2/urlfetch-cache branch Nov 12, 2018

}).to_boxed()
}).and_then(move |(actual_digest, file_name, tempdir)| {
let hasher = hashing::WriterHasher::new(SizeLimiter {

This comment has been minimized.

@blorente

blorente Nov 12, 2018

Contributor

You found an instance where I miss the Java anonymous classes to implement interfaces like this. That said, I don't disagree with this code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment