Buffer downloads in memory not on disk #6746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuhood
approved these changes
Nov 9, 2018
| @@ -100,6 +101,7 @@ def create_scheduler(rules, validate=True, native=None): | |||
| native, | |||
| FileSystemProjectTree(os.getcwd()), | |||
| './.pants.d', | |||
| safe_mkdtemp(), | |||
There was a problem hiding this comment.
Is this a good default? Or do we want to default to the usual/global directory unless it's been overridden?
ity
approved these changes
Nov 9, 2018
illicitonion
force-pushed
the
dwagnerhall/v2/urlfetch-cache
branch
from
189e59d
to
653e279
Compare
illicitonion
force-pushed
the
dwagnerhall/v2/urlfetch-cache
branch
from
653e279
to
e197e93
Compare
illicitonion
changed the title
blorente
reviewed
Nov 12, 2018
| }).to_boxed() | ||
| }).and_then(move |(actual_digest, file_name, tempdir)| { | ||
|
|
||
| let hasher = hashing::WriterHasher::new(SizeLimiter { |
There was a problem hiding this comment.
You found an instance where I miss the Java anonymous classes to implement interfaces like this. That said, I don't disagree with this code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.