Force consistent stty size on travis #6768
Conversation
It apparently got much narrower yesterday, which causes some tests which are sensitive to stty width (around parsing pytest output) to fail.
| stty rows 60 |
There was a problem hiding this comment.
A comment would be great as to why. I think its probably horrible that we have tests that parse output (and to boot, in this fragile a way). Calling attention to this magic as a hack to support the test hacks seems like a good idea for future cleanup expeditions to be more fearless.
There was a problem hiding this comment.
Very open to feedback on the tests in #6661 which are the relevant ones (which I just added).
In the mean time, I'll add a comment and merge to get master green.
There was a problem hiding this comment.
Aha. Well, in that case, setting TERM=dumb and / or COLUMNS=XYZ inside just those tests makes a lot more sense to me.
|
Both of the failures are flakes, and @illicitonion is gone for the day. Going to merge to get master green, and then we can loop back to isolate the fix. |
This reverts commit b2ac372.
It apparently got much narrower yesterday, which causes some tests which
are sensitive to stty width (around parsing pytest output) to fail.