Fix linter running on intentionally bad Thrift test files #6943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
./pants lint :: was not running against the intentionally bad Thrift files we use for testing, until this PR changed those files so surfaced the issue. This commit implements the TEST_BUILD pattern to work around the linter complaining.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
./pants lint ::had never ran against the intentionally bad Thrift files we use for testing Scrooge. While working on #6913, due to changes made to the files,./pants lint ::started to complain about them.These files are intentionally bad, so
./pants lint ::complaining is not helpful.Solution
Use the
TEST_BUILDpattern to work around the linter complaining. We name theBUILDfile insteadTEST_BUILD, and then during the unit test use a context manager to temporarily rename toBUILD.