Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@union / UnionRule for letting the engine figure out paths to products not known in advance #7116

Merged
merged 19 commits into from Mar 6, 2019
Merged

@union / UnionRule for letting the engine figure out paths to products not known in advance #7116

merged 19 commits into from Mar 6, 2019

Commits on Mar 3, 2019

  1. separate the declared type from the actual subject type of the Get

    @cosmicexplorer
    cosmicexplorer committed Mar 3, 2019
    Copy the full SHA
    18bfd47 View commit details
    Browse the repository at this point in the history

  2. plumb a dict of type constraint -> list<type constraint> for unions i… 

    …nto the engine
    @cosmicexplorer
    cosmicexplorer committed Mar 3, 2019
    Copy the full SHA
    6fa19b8 View commit details
    Browse the repository at this point in the history

  3. add testing for union rules which fails

    @cosmicexplorer
    cosmicexplorer committed Mar 3, 2019
    Copy the full SHA
    7f24f9f View commit details
    Browse the repository at this point in the history

  4. union rules work now

    @cosmicexplorer
    cosmicexplorer committed Mar 3, 2019
    Copy the full SHA
    709e2dc View commit details
    Browse the repository at this point in the history

  5. introduce Get.create_statically_for_rule_graph() to avoid confusion

    @cosmicexplorer
    cosmicexplorer committed Mar 3, 2019
    Copy the full SHA
    affab03 View commit details
    Browse the repository at this point in the history

  6. introduce a wrapper datatype for normalized_rules() for no particular… 

    … reason
    @cosmicexplorer
    cosmicexplorer committed Mar 3, 2019
    Copy the full SHA
    78f87fb View commit details
    Browse the repository at this point in the history

  7. flesh out docstrings

    @cosmicexplorer
    cosmicexplorer committed Mar 3, 2019
    Copy the full SHA
    eea0f6f View commit details
    Browse the repository at this point in the history

  8. add union_rules to all Scheduler() constructions

    @cosmicexplorer
    cosmicexplorer committed Mar 3, 2019
    Copy the full SHA
    fdda871 View commit details
    Browse the repository at this point in the history

  9. add followup issue link for graph visualization

    @cosmicexplorer
    cosmicexplorer committed Mar 3, 2019
    Copy the full SHA
    4aebfc4 View commit details
    Browse the repository at this point in the history

  10. test the Get typechecking which we now do during rule execution 

    also test Get.extract_constraints()!
    @cosmicexplorer
    cosmicexplorer committed Mar 3, 2019
    Copy the full SHA
    23ca41b View commit details
    Browse the repository at this point in the history

  11. add further checking to Get() arguments to overcome ambiguity that le… 

    …d to test failure
    @cosmicexplorer
    cosmicexplorer committed Mar 3, 2019
    Copy the full SHA
    3f48ac5 View commit details
    Browse the repository at this point in the history

  12. make bundles and sources fields use union rules

    @cosmicexplorer
    cosmicexplorer committed Mar 3, 2019
    Copy the full SHA
    872921a View commit details
    Browse the repository at this point in the history

  13. remove all knowledge of union rules from the engine

    @cosmicexplorer
    cosmicexplorer committed Mar 3, 2019
    Copy the full SHA
    cc421d4 View commit details
    Browse the repository at this point in the history

  14. turn panics into throws and make union tests pass!

    @cosmicexplorer
    cosmicexplorer committed Mar 3, 2019
    Copy the full SHA
    eb928c1 View commit details
    Browse the repository at this point in the history

  15. remove @union_rule for UnionRule() datatype and add docstrings

    @cosmicexplorer
    cosmicexplorer committed Mar 3, 2019
    Copy the full SHA
    07f5835 View commit details
    Browse the repository at this point in the history

  16. cleanup in response to review comments

    @cosmicexplorer
    cosmicexplorer committed Mar 3, 2019
    Copy the full SHA
    628de1c View commit details
    Browse the repository at this point in the history

  17. remove now-unused native lib helper

    @cosmicexplorer
    cosmicexplorer committed Mar 3, 2019
    Copy the full SHA
    93e2f4e View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2019

  1. flesh out the error message TODO!

    @cosmicexplorer
    cosmicexplorer committed Mar 5, 2019
    Copy the full SHA
    8d4eb55 View commit details
    Browse the repository at this point in the history

  2. fix error message test

    @cosmicexplorer
    cosmicexplorer committed Mar 5, 2019
    Copy the full SHA
    5d58801 View commit details
    Browse the repository at this point in the history