remove support for using the pants native toolchain with distutils Extensions in setup.py

build-support/known_py3_pex_failures.txt

@@ -1,7 +1,6 @@
 tests/python/pants_test/backend/jvm/tasks:scala_repl_integration
 tests/python/pants_test/backend/python/tasks:integration
-tests/python/pants_test/backend/python/tasks:isort_run_integration
-tests/python/pants_test/backend/python/tasks:python_native_code_testing_1
+tests/python/pants_test/backend/python:integration
 tests/python/pants_test/base:exiter_integration
 tests/python/pants_test/engine/legacy:changed_integration
 tests/python/pants_test/engine/legacy:console_rule_integration

src/python/pants/backend/native/tasks/conan_fetch.py

@@ -133,8 +133,9 @@ def execute_codegen(self, target, target_workdir):
             .format(cmdline, env, exit_code),
             exit_code=exit_code)
 
-        # Read the stdout from the read-write buffer, from the beginning of the output.
-        conan_install_stdout = workunit.output('stdout').read_from(0)
+        # Read the stdout from the read-write buffer, from the beginning of the output, and convert
+        # to unicode.
+        conan_install_stdout = workunit.output('stdout').read_from(0).decode('utf-8')
         pkg_sha = conan_requirement.parse_conan_stdout_for_pkg_sha(conan_install_stdout)
 
       installed_data_dir = os.path.join(

src/python/pants/backend/python/subsystems/python_native_code.py

@@ -4,15 +4,10 @@
 
 from __future__ import absolute_import, division, print_function, unicode_literals
 
-import os
 from builtins import str
 from collections import defaultdict
 
-from pex.pex import PEX
-
-from pants.backend.native.config.environment import CppToolchain, CToolchain, Platform
 from pants.backend.native.subsystems.native_toolchain import NativeToolchain
-from pants.backend.native.subsystems.xcode_cli_tools import MIN_OSX_VERSION_ARG
 from pants.backend.native.targets.native_library import NativeLibrary
 from pants.backend.python.python_requirement import PythonRequirement
 from pants.backend.python.subsystems.python_setup import PythonSetup
@@ -22,8 +17,7 @@
 from pants.binaries.executable_pex_tool import ExecutablePexTool
 from pants.subsystem.subsystem import Subsystem
 from pants.util.memo import memoized_property
-from pants.util.objects import SubclassesOf, datatype
-from pants.util.strutil import create_path_env_var
+from pants.util.objects import SubclassesOf
 
 
 class PythonNativeCode(Subsystem):
@@ -65,14 +59,11 @@ def _python_setup(self):
   def pydist_has_native_sources(self, target):
     return target.has_sources(extension=tuple(self._native_source_extensions))
 
-  def native_target_has_native_sources(self, target):
-    return target.has_sources()
-
   @memoized_property
   def _native_target_matchers(self):
     return {
       SubclassesOf(PythonDistribution): self.pydist_has_native_sources,
-      SubclassesOf(NativeLibrary): self.native_target_has_native_sources,
+      SubclassesOf(NativeLibrary): NativeLibrary.produces_ctypes_native_library,
     }
 
   def _any_targets_have_native_sources(self, targets):
@@ -158,68 +149,3 @@ def base_requirements(self):
       PythonRequirement('setuptools=={}'.format(self.python_setup.setuptools_version)),
       PythonRequirement('wheel=={}'.format(self.python_setup.wheel_version)),
     ]
-
-
-class SetupPyNativeTools(datatype([
-    ('c_toolchain', CToolchain),
-    ('cpp_toolchain', CppToolchain),
-    ('platform', Platform),
-])):
-  """The native tools needed for a setup.py invocation.
-
-  This class exists because `SetupPyExecutionEnvironment` is created manually, one per target.
-  """
-
-
-# TODO: It might be pretty useful to have an Optional TypeConstraint.
-class SetupPyExecutionEnvironment(datatype([
-    # If None, don't set PYTHONPATH in the setup.py environment.
-    ('setup_requires_pex', PEX),
-    # If None, don't execute in the toolchain environment.
-    'setup_py_native_tools',
-])):
-
-  _SHARED_CMDLINE_ARGS = {
-    'darwin': lambda: [
-      MIN_OSX_VERSION_ARG,
-      '-Wl,-dylib',
-      '-undefined',
-      'dynamic_lookup',
-    ],
-    'linux': lambda: ['-shared'],
-  }
-
-  def as_environment(self):
-    ret = {}
-
-    # TODO(#5951): the below is a lot of error-prone repeated logic -- we need a way to compose
-    # executables more hygienically. We should probably be composing each datatype's members, and
-    # only creating an environment at the very end.
-    native_tools = self.setup_py_native_tools
-    if native_tools:
-      # An as_tuple() method for datatypes could make this destructuring cleaner!  Alternatively,
-      # constructing this environment could be done more compositionally instead of requiring all of
-      # these disparate fields together at once.
-      c_toolchain = native_tools.c_toolchain
-      c_compiler = c_toolchain.c_compiler
-      c_linker = c_toolchain.c_linker
-
-      cpp_toolchain = native_tools.cpp_toolchain
-      cpp_compiler = cpp_toolchain.cpp_compiler
-      cpp_linker = cpp_toolchain.cpp_linker
-
-      all_path_entries = (
-        c_compiler.path_entries +
-        c_linker.path_entries +
-        cpp_compiler.path_entries +
-        cpp_linker.path_entries)
-      # TODO(#6273): We prepend our toolchain to the PATH instead of overwriting it -- we need
-      # better control of the distutils compilation environment if we want to actually isolate the
-      # PATH (distutils does lots of sneaky things).
-      ret['PATH'] = create_path_env_var(all_path_entries, env=os.environ.copy(), prepend=True)
-
-      # GCC will output smart quotes in a variety of situations (leading to decoding errors
-      # downstream) unless we set this environment variable.
-      ret['LC_ALL'] = 'C'
-
-    return ret