Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare the 1.15.0rc0 release. #7398

Merged
merged 2 commits into from Mar 19, 2019

Conversation

stuhood
Copy link
Sponsor Member

@stuhood stuhood commented Mar 18, 2019

No description provided.

Copy link
Contributor

@cosmicexplorer cosmicexplorer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of exciting changes!!

Copy link
Contributor

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woohoo!

We've discussed this a bit over Slack. Because we've now put out to the universe that 1.15.0 is the first stable release to support Py3, we might need to cherry-pick a few PRs in these RCs. The remaining issues we have:

  • Py37 CI
  • Releasing as Py3 compatible PEX
  • Fixing flaky Idea test
  • Fixing Python tasks test, which I think is blocked by Pex upgrade
  • Fixing console test, which I think was blocked by Pex upgrade but not sure

Of these, the only that seems essential to cherry-pick is releasing as Py3 Pex, along with any of the test fixes if they end up involving changes to src code. Consequently, I'll prioritize pursuing that.

@stuhood
Copy link
Sponsor Member Author

stuhood commented Mar 18, 2019

Of these, the only that seems essential to cherry-pick is releasing as Py3 Pex, along with any of the test fixes if they end up involving changes to src code. Consequently, I'll prioritize pursuing that.

Which changes are blocking that, do we think?

@Eric-Arellano
Copy link
Contributor

Which changes are blocking that [i.e. releasing as Py3 compatible PEX], do we think?

If this is out of scope or it takes too long to land, I do not think it's the end of the world to wait for Py3 support for Pex until 1.16.0.

Alternatively, we could temporarily release a Pex27, Pex36, and Pex37 like Pex does. Thoughts?

@stuhood
Copy link
Sponsor Member Author

stuhood commented Mar 18, 2019

Alternatively, we could temporarily release a Pex27, Pex36, and Pex37 like Pex does. Thoughts?

That would be a much more reasonable thing to cherry pick I think.

@stuhood stuhood merged commit 6744c9d into pantsbuild:master Mar 19, 2019
@stuhood stuhood deleted the stuhood/prepare-1.15.0rc0 branch March 19, 2019 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants