Consolidate JSON stats recording in RunTracker #7446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like this was added to survive a clean-all, but is not accessed. A User can determine if they'd like to write a JSON already for the build, so let's only write it then if configured.
codealchemy
commented
Mar 27, 2019
| @@ -67,7 +67,7 @@ def test_write_stats_to_json_file(self): | |||
|
|
|||
| # Execute & verify | |||
| with temporary_file_path() as file_name: | |||
| self.assertTrue(RunTracker.write_stats_to_json(file_name, stats)) | |||
There was a problem hiding this comment.
This was the only place I could find where we used the return value from that method - since we're testing the file exists / matches output below that seemed unnecessary (and I've removed the boolean return values in the method itself).
benjyw
approved these changes
Mar 27, 2019
stuhood
approved these changes
Mar 28, 2019
benjyw
pushed a commit
that referenced
this pull request
Apr 2, 2019
Followup to #7446. The schema for StatsDB is coupled to the current output of stats used in the RunTracker - which complicates any attempts to move to a new stats schema (ie. the JsonReporter). Given that the only usage of StatsDB was for the timing views from ./pants server, and those views are not heavily used (as far as could be determined in related Slack convo), this should be safe to remove.
jsirois
pushed a commit
that referenced
this pull request
Apr 4, 2019
Prior / related work: #7475, #7474, #7446, #7392 Adds an option to the `RunTracker` (defaulting to current behavior) to permit selecting which json schema for recording stats. ### V1 https://github.com/pantsbuild/pants/blob/76415e5902672b70965568acf42f12eca2a32b1b/src/python/pants/goal/run_tracker.py#L414-L423 ### V2 https://github.com/pantsbuild/pants/blob/76415e5902672b70965568acf42f12eca2a32b1b/src/python/pants/reporting/json_reporter.py#L63-L68
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently write JSON two ways - one of which doesn't seem needed at all (writing to a cache that isn't accessed anywhere). This cleans that up a bit in preparation for adding the
JsonReporteras an option for JSON output.馃摑 One thing of note is the StatsDb schema is coupled to the current stats JSON.
pants/src/python/pants/stats/statsdb.py
Lines 80 to 82 in 6739a81
If that view (
<pants server url>/stats/) is not currently providing much value to users, there is quite a bit more that can be removed as a followup to this change.