Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve logging of build-support/isort.sh helper script #7503

Merged
merged 4 commits into from Apr 5, 2019
Merged

Improve logging of build-support/isort.sh helper script #7503

merged 4 commits into from Apr 5, 2019

Commits on Apr 5, 2019

  1. Improve logging our isort.sh helper script

    @Eric-Arellano
    Eric-Arellano committed Apr 5, 2019
    Copy the full SHA
    370c646 View commit details
    Browse the repository at this point in the history

  2. Fancier grep thanks to Danny

    @Eric-Arellano
    Eric-Arellano committed Apr 5, 2019
    Copy the full SHA
    d07919f View commit details
    Browse the repository at this point in the history

  3. Simplify

    @Eric-Arellano
    Eric-Arellano committed Apr 5, 2019
    Copy the full SHA
    0ad51dd View commit details
    Browse the repository at this point in the history

  4. Try to fix issue with return codes 

    If the grep search failed, we would return an error code of 1 unintentionally.
    @Eric-Arellano
    Eric-Arellano committed Apr 5, 2019
    Copy the full SHA
    8d012f6 View commit details
    Browse the repository at this point in the history