fix --owner-of path matching to remove repeated directory separators #7588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cosmicexplorer
force-pushed
the
fix-file-path-repeated-slash
branch
from
6a06a5c
to
b5b1384
Compare
stuhood
reviewed
Apr 18, 2019
stuhood
approved these changes
Apr 19, 2019
| @@ -592,12 +593,14 @@ def check(val): | |||
| merged_rank = ranked_vals[-1].rank | |||
| merged_val = ListValueComponent.merge( | |||
| [rv.value for rv in ranked_vals if rv.value is not None]).val | |||
| # TODO: run `check()` for all elements of a list option too!!! | |||
There was a problem hiding this comment.
Or merge check with _convert_member_type? But yea, in a followup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
@wisechengyi brought this up in another chat, where repeated forward slashes would cause silent errors in target detection for
--owner-of, returning only the first owning target in cases where multiple targets owned the same file (seetest_owner_list_repeated_directory_separator()in the diff for an example).Solution
/in allfile_option,dir_option, andtarget_optionoptions.Result
Paths to files for
--owner-ofdetection can contain multiple forward slashes in a row, and that potentially makes them easier to generate by script.