Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put all arguments to javac in safe_args not just the source paths #7651

Merged
merged 1 commit into from May 7, 2019

Conversation

Projects
None yet
2 participants
@cheister
Copy link
Contributor

commented May 2, 2019

Problem

We had some builds where the classpath for javac was too long for the command line to interpret

Solution

Batch all arguments to javac, not just the source paths, in the safe_args @ file

Result

Everything except for the -J args to javac can be put into an argument file and the length of the classpath or the number of files won't be limited by the command line length.

@cheister cheister requested a review from stuhood May 2, 2019

@stuhood

stuhood approved these changes May 2, 2019

Copy link
Member

left a comment

Thanks!

@cheister cheister force-pushed the cheister:safe-args-javac-classpath branch from b1ebea6 to 80ee8cc May 3, 2019

@cheister cheister force-pushed the cheister:safe-args-javac-classpath branch from 80ee8cc to aaeb976 May 6, 2019

@cheister cheister merged commit 050b4a3 into pantsbuild:master May 7, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@cheister cheister deleted the cheister:safe-args-javac-classpath branch May 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.