Put all arguments to javac in safe_args not just the source paths #7651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cheister
force-pushed
the
safe-args-javac-classpath
branch
from
b1ebea6
to
80ee8cc
Compare
cheister
force-pushed
the
safe-args-javac-classpath
branch
from
80ee8cc
to
aaeb976
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We had some builds where the classpath for javac was too long for the command line to interpret
Solution
Batch all arguments to javac, not just the source paths, in the safe_args @ file
Result
Everything except for the
-Jargs to javac can be put into an argument file and the length of the classpath or the number of files won't be limited by the command line length.