add java_sources to scala_library() snapshot #7840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This had a bootstrap shard fail in travis: have restarted things. |
cosmicexplorer
force-pushed
the
fix-java-sources-snapshot
branch
from
0ece427
to
ed3956c
Compare
cosmicexplorer
added a commit
that referenced
this pull request
Jun 5, 2019
### Problem Zinc or rsc compiles with `--execution-strategy=hermetic` will fail on `scala_library()` targets with `java_sources`, because those sources aren't added into the source snapshot, and zinc fails with an opaque error: ``` [error] IO error while decoding /Users/dmcclanahan/tools/pants/.pants.d/tmp/tmpfv8ds506.pants.d/process-executionUP7R5m/testprojects/src/java/org/pantsbuild/testproject/javasources/JavaSource.java with UTF-8: /Users/dmcclanahan/tools/pants/.pants.d/tmp/tmpfv8ds506.pants.d/process-executionUP7R5m/testprojects/src/java/org/pantsbuild/testproject/javasources/JavaSource.java (No such file or directory) [error] Please try specifying another one using the -encoding option ``` ### Solution - Add the sources from `java_sources` targets into the `sources_snapshot()` for a `scala_library()` target. ### Result `java_sources` works with hermetic compiles!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Zinc or rsc compiles with
--execution-strategy=hermeticwill fail onscala_library()targets withjava_sources, because those sources aren't added into the source snapshot, and zinc fails with an opaque error:Solution
java_sourcestargets into thesources_snapshot()for ascala_library()target.Result
java_sourcesworks with hermetic compiles!